readlinkat(2): allow O_PATH fd
ClosedPublic
Actions

Authored by kib on Oct 9 2021, 5:16 AM.

Details

Reviewers

markj
ashish

Commits

rG5fb54d2fc845: readlinkat(2): allow O_PATH fd

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

kib created this revision.Oct 9 2021, 5:16 AM

Herald added a subscriber: imp. · View Herald TranscriptOct 9 2021, 5:16 AM

kib requested review of this revision.Oct 9 2021, 5:16 AM

Update man page

I tested it, and seems to resolve the PR 258856. If you could reference the PR in the commit message that'll be great.

Appreciate your quick follow-up.

Thank you!

This revision is now accepted and ready to land.Oct 9 2021, 3:43 PM

What does it have to do with O_PATH fds? After this patch readlinkat(fd, "", buf, bufsz) will succeed even if fd is opened without O_PATH, I believe.

In D32390#731040, @markj wrote:

What does it have to do with O_PATH fds? After this patch readlinkat(fd, "", buf, bufsz) will succeed even if fd is opened without O_PATH, I believe.

We do not allow opening symlink without O_PATH. See the very beginning of vn_open_vnode().

Closed by commit rG5fb54d2fc845: readlinkat(2): allow O_PATH fd (authored by kib). · Explain WhyOct 9 2021, 7:32 PM

This revision was automatically updated to reflect the committed changes.

kib added a commit: rG5fb54d2fc845: readlinkat(2): allow O_PATH fd.