Page MenuHomeFreeBSD

[docs] Remove i386-wine from docs
Needs RevisionPublic

Authored by Alexander88207_protonmail.com on Oct 4 2021, 9:47 PM.
Tags
Referenced Files
Unknown Object (File)
Mon, Apr 8, 1:11 PM
Unknown Object (File)
Mon, Apr 8, 1:11 PM
Unknown Object (File)
Mon, Apr 8, 1:06 PM
Unknown Object (File)
Mon, Apr 8, 1:06 PM
Unknown Object (File)
Mon, Apr 8, 11:11 AM
Unknown Object (File)
Mon, Apr 8, 3:54 AM
Unknown Object (File)
Feb 8 2024, 6:23 AM
Unknown Object (File)
Dec 20 2023, 6:53 AM

Details

Reviewers
pauamma_gundo.com
Group Reviewers
docs
Summary

emulators/wine and the others now also provide i386 wine simultaneously so the standalone i386-wine ports are obsolete.

While here fix wrong Wine spelling (WINE --> Wine).

Diff Detail

Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

Alexander88207_protonmail.com planned changes to this revision.
Alexander88207_protonmail.com created this revision.
Alexander88207_protonmail.com retitled this revision from [WIP] Remove i386-wine from docs to [docs] Remove i386-wine from docs.Oct 15 2021, 8:13 PM

Could you please update the diff to one made using the instructions on the Phabricator wiki article?

I don't think enough context was included, because I'm still seeing "Context not available" - any chance you can use arcanist from ports/packages (as described on the wiki article I linked earlier) or src/tools/tools/git/git-arc.sh (which can be installed by doing make -C /usr/src/tools/tools/git/ install (which requires arcanist, git, and textproc/jq?

documentation/content/en/books/handbook/wine/_index.adoc
262

This comment feels a bit needlessly snide.
Perhaps change it so that it's "as of a change in Wine, ca. 2021, it is now possible to use both 32bit and 64bit applications", or something to that effect.

267

Any chance you can add instructions for how to do the port using chroot?

355

Are you sure the binary and directory is capitalized? I think your regex was a bit too aggressive ;)

365

One more instance of aggressive regex.

753

Another instance of aggressive regex.

iwtcex_gmail.com added inline comments.
documentation/content/en/books/handbook/wine/_index.adoc
251

"WoW64 support" is the most natural title in my opinion.

262

How about we skip this paragraph and merge "problem" with "workaround" lines? Something like "Because the Ports Collection doesn't allow building multilib packages, the port contains a workaround allowing side-by-side installation of i386 packages…".

I definitely would not represent this as a change in Wine, that's not what it is.

267

It would be more fair to say that aforementioned workaround does nothing to simplify the building process for 32-bit Wine, because that's precisely the same procedure as described at https://wiki.freebsd.org/i386-Wine#Building. That is, nothing is more complex than it already were.

779–783

Obsolete section.

Still missing full diff context.

Also needs screenreader-friendly descriptions of the included images for accessibility. (I don't use Wine or Windows, so I can't gauge what needs to go into those.)

documentation/content/en/books/handbook/wine/_index.adoc
55

s/to install and run/installing and running/

73

s/At the end of the day/In summary/ (more readily understood by EFL readers)

130

Is "backed" a typo for "backend"? Otherwise a word is missing there.

174

s/existing/exiting/

While there, I'd also s/in order to boot/to boot/

184

s/Prerequistes/Prerequisites/

240

s/pre-requisites/prerequisites/ for consistency

254

Instinct tells me "subsystem" is the preferred US English spelling, but it's been known to be wrong.

259

s/install/install clean/

329

s/the wine/Wine/? Or is it "the Wine/wine (something)"?

425

s/Create/Creating/ for consistency with surrounding list items.

436

Same sub-system/subsystem question as above.

475

While here, maybe dispense with the snide aside about those unnamed other operating systems?

480

s/it is/its/

494

s/commands/command/

506

s/install/install clean/

573

s/than/instead of/ (Or simplify: "However, it's in the _games_ ports category, not _emulators_.")

578

s/install/install clean/

735

s/as whom the Wine programs will be running/the Wine programs will be running as/

787–790

I'm not comfortable with how this is framed. If that's useful to try but not guaranteed to work for everyone or in all cases, just say that, without linking to that post and enabling trolling the poster.

834

Same as above.

836

Already available.

[pauamma@gadfly] ~% pkg search wine-proton
wine-proton-6.3.2_5            Wine with a bit of extra spice
837

s/will bring/brings/ (per above)

This revision now requires changes to proceed.May 20 2022, 10:51 PM

Can you please share the images with me by email?
carlavilla@FreeBSD.org

Thanks for the upgrade of the chapter :)
We can continue with it if you want.