Page MenuHomeFreeBSD

Fix busdma resource leak on usb device detach
ClosedPublic

Authored by ian on Sep 28 2021, 4:20 PM.
Tags
None
Referenced Files
F104638571: D32208.diff
Sun, Dec 8, 12:29 PM
Unknown Object (File)
Oct 1 2024, 2:39 PM
Unknown Object (File)
Sep 22 2024, 6:43 PM
Unknown Object (File)
Sep 21 2024, 1:35 PM
Unknown Object (File)
Sep 16 2024, 2:20 AM
Unknown Object (File)
Sep 15 2024, 11:10 PM
Unknown Object (File)
Sep 15 2024, 10:52 PM
Unknown Object (File)
Sep 15 2024, 7:37 PM
Subscribers

Details

Summary

When a usb device is detached, usb_pc_dmamap_destroy() called bus_dmamap_destroy() while the map was still loaded. That's harmless on x86 architectures, but on all other platforms it causes bus_dmamap_destroy() to return EBUSY and leak away any memory resources (including bounce buffers) associated with the mapping, as well as any allocated map structure itself.

This change introduces a new is_loaded flag to the usb_page_cache struct to track whether a map is loaded or not. If the map is loaded, bus_dmamap_unload() is called before bus_dmamap_destroy() to avoid leaking away resources.

Test Plan

On a non-x86 platform such as arm, sysctl vm.kvm_free can be used to track the resource leaks. Before this change, you can see kvm_free go down with each usb device attach/detach. (Using usbconfig reset in a shell while 1 loop will eventually run the kernel out of memory and hang or panic the system.) After this change, the sysctl shows no change in kvm_free across multiple attach/detach cycles.

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Skipped
Unit
Tests Skipped
Build Status
Buildable 41814