On some platforms, the /cpus entry contains cpu-to-cluster
map which deffinitely is not a CPU device. Its presence was
causing incrementing of "id" variable and reporting more
CPUs available than it should.
To make "id" valid, increment it only when an entry really
is a CPU.
Details
Details
Diff Detail
Diff Detail
- Repository
- rS FreeBSD src repository - subversion
- Lint
Lint Not Applicable - Unit
Tests Not Applicable
Event Timeline
Comment Actions
I'm not sure we need a goto in the loop, finding the next id is simple to do when we know we have a cpu node.
| sys/dev/ofw/ofw_cpu.c | ||
|---|---|---|
| 300 ↗ | (On Diff #7370) | u_int next_id;
...
next_id = 0;
...
for (child = OF_child(node); child != 0; child = OF_peer(child), id = next_id) { |
| 310 ↗ | (On Diff #7370) | next_id++; |
| 319 ↗ | (On Diff #7370) | Then revert this |
| 329 ↗ | (On Diff #7370) | And this |
| 333 ↗ | (On Diff #7370) | etc. |
Comment Actions
Just need to fix the minor style issue before committing.
| sys/dev/ofw/ofw_cpu.c | ||
|---|---|---|
| 301 ↗ | (On Diff #7424) | This line will need to be split as it was already at 80 characters. |