Page MenuHomeFreeBSD

cam: Avoiding waking up doneq threads if we're dumping
ClosedPublic

Authored by markj on Sep 24 2021, 7:40 PM.
Tags
None
Referenced Files
Unknown Object (File)
Sat, Jul 18, 2:31 AM
Unknown Object (File)
Tue, Jul 14, 7:57 PM
Unknown Object (File)
Wed, Jul 8, 5:33 PM
Unknown Object (File)
Sun, Jul 5, 11:58 PM
Unknown Object (File)
Sun, Jul 5, 3:38 AM
Unknown Object (File)
Sat, Jul 4, 8:05 PM
Unknown Object (File)
Thu, Jul 2, 7:11 AM
Unknown Object (File)
Mon, Jun 29, 9:01 PM
Subscribers

Details

Summary

Depending on the state of the doneq thread at the time of the panic, the
wakeup can hang indefinitely in thread_lock_block_wait(). I think that
function should be modified to return immediately if the scheduler is
stopped, but it also seems more robust to avoid wakeups in general after
a panic.

Reported by: pho

Test Plan

Peter reported occasional hangs while dumping core after a panic,
resolved by this patch.

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable