Page MenuHomeFreeBSD

cam: Avoiding waking up doneq threads if we're dumping
ClosedPublic

Authored by markj on Sep 24 2021, 7:40 PM.
Tags
None
Referenced Files
Unknown Object (File)
Sun, Oct 12, 12:42 AM
Unknown Object (File)
Sat, Sep 27, 1:30 AM
Unknown Object (File)
Sep 15 2025, 10:03 PM
Unknown Object (File)
Sep 10 2025, 9:45 PM
Unknown Object (File)
Sep 4 2025, 10:59 AM
Unknown Object (File)
Aug 28 2025, 4:05 PM
Unknown Object (File)
Aug 26 2025, 3:40 PM
Unknown Object (File)
Aug 18 2025, 1:10 PM
Subscribers

Details

Summary

Depending on the state of the doneq thread at the time of the panic, the
wakeup can hang indefinitely in thread_lock_block_wait(). I think that
function should be modified to return immediately if the scheduler is
stopped, but it also seems more robust to avoid wakeups in general after
a panic.

Reported by: pho

Test Plan

Peter reported occasional hangs while dumping core after a panic,
resolved by this patch.

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable