Page MenuHomeFreeBSD

cam: Avoiding waking up doneq threads if we're dumping
ClosedPublic

Authored by markj on Sep 24 2021, 7:40 PM.
Tags
None
Referenced Files
F169682798: D32126.id95668.diff
Wed, Sep 2, 7:03 AM
F169585095: D32126.id95719.diff
Tue, Sep 1, 11:53 PM
F169552075: D32126.diff
Tue, Sep 1, 9:48 PM
Unknown Object (File)
Wed, Aug 19, 11:16 PM
Unknown Object (File)
Thu, Aug 13, 6:23 PM
Unknown Object (File)
Thu, Aug 13, 5:57 PM
Unknown Object (File)
Wed, Aug 12, 12:56 PM
Unknown Object (File)
Tue, Aug 11, 11:25 PM
Subscribers

Details

Summary

Depending on the state of the doneq thread at the time of the panic, the
wakeup can hang indefinitely in thread_lock_block_wait(). I think that
function should be modified to return immediately if the scheduler is
stopped, but it also seems more robust to avoid wakeups in general after
a panic.

Reported by: pho

Test Plan

Peter reported occasional hangs while dumping core after a panic,
resolved by this patch.

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable