Page MenuHomeFreeBSD

cam: Avoiding waking up doneq threads if we're dumping
ClosedPublic

Authored by markj on Sep 24 2021, 7:40 PM.
Tags
None
Referenced Files
Unknown Object (File)
Thu, Jun 25, 8:06 AM
Unknown Object (File)
Mon, Jun 22, 9:48 PM
Unknown Object (File)
Mon, Jun 8, 6:37 PM
Unknown Object (File)
May 26 2026, 1:43 AM
Unknown Object (File)
May 7 2026, 9:17 AM
Unknown Object (File)
Apr 29 2026, 3:20 AM
Unknown Object (File)
Apr 29 2026, 3:12 AM
Unknown Object (File)
Apr 27 2026, 6:55 PM
Subscribers

Details

Summary

Depending on the state of the doneq thread at the time of the panic, the
wakeup can hang indefinitely in thread_lock_block_wait(). I think that
function should be modified to return immediately if the scheduler is
stopped, but it also seems more robust to avoid wakeups in general after
a panic.

Reported by: pho

Test Plan

Peter reported occasional hangs while dumping core after a panic,
resolved by this patch.

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable