Page MenuHomeFreeBSD

cam: Avoiding waking up doneq threads if we're dumping
ClosedPublic

Authored by markj on Sep 24 2021, 7:40 PM.
Tags
None
Referenced Files
F166142928: D32126.id95668.diff
Tue, Aug 11, 11:25 PM
Unknown Object (File)
Mon, Aug 10, 12:14 PM
Unknown Object (File)
Mon, Aug 10, 12:14 PM
Unknown Object (File)
Sat, Aug 8, 7:33 PM
Unknown Object (File)
Sat, Jul 25, 2:05 AM
Unknown Object (File)
Wed, Jul 22, 11:28 PM
Unknown Object (File)
Tue, Jul 21, 1:05 PM
Unknown Object (File)
Tue, Jul 21, 2:46 AM
Subscribers

Details

Summary

Depending on the state of the doneq thread at the time of the panic, the
wakeup can hang indefinitely in thread_lock_block_wait(). I think that
function should be modified to return immediately if the scheduler is
stopped, but it also seems more robust to avoid wakeups in general after
a panic.

Reported by: pho

Test Plan

Peter reported occasional hangs while dumping core after a panic,
resolved by this patch.

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable