Page MenuHomeFreeBSD

buffer pager: allow get_blksize method to return error
ClosedPublic

Authored by kib on Sep 16 2021, 11:58 PM.

Diff Detail

Repository
R10 FreeBSD src repository
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

Why are you changing the blksz from an int to a long? The commit message doesn't mention that.

Why are you changing the blksz from an int to a long? The commit message doesn't mention that.

Either bsize should be changed to int, or bo_bs to long. It is clear from the code, I decided not to explain trivial things. I (randomly) preferred bsize, since it is passed to other API place.

The change looks fine. But the commit message is incomplete, because it doesn't mention removing the panic in fuse. Should I merge this change into D31994 ?

The change looks fine. But the commit message is incomplete, because it doesn't mention removing the panic in fuse. Should I merge this change into D31994 ?

If you want to keep fusefs fix for youself, I can drop it there, only modifying fusefs pager vop to return 0 as error. Is this fine with you?

Drop part of fusefs patch, remove removal of the kassert and returning error.

Yes, I think that makes more sense.

This revision is now accepted and ready to land.Sep 17 2021, 4:52 PM