Page MenuHomeFreeBSD

mana: Cast an unused value to void to quiet a warning.
ClosedPublic

Authored by jhb on Mon, Sep 13, 6:28 PM.

Details

Summary

This appeases a -Wunused-value warning from GCC 9.

Diff Detail

Repository
R10 FreeBSD src repository
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

jhb requested review of this revision.Mon, Sep 13, 6:28 PM

Adding an atomic_inc() wrapper might be a cleaner way of fixing this.

sys/dev/mana/mana_en.c
579

why not just atmoic_inc?

sys/dev/mana/mana_en.c
579

Because we don't have it yet and would need to add a wrapper in the foo.h compat header that defines atomic_inc_return(). I did suggest it as an alternative though if that would be cleaner.

Thanks for fixing this warning.

This revision is now accepted and ready to land.Thu, Sep 16, 4:01 AM