Page MenuHomeFreeBSD
Differential D31946

posixshmtest: Fix various warnings raised by GCC.
ClosedPublic
Actions

Authored by jhb on Sep 13 2021, 6:26 PM.
Tags
None
Referenced Files
F163087296: D31946.id95211.diff
Sun, Jul 19, 11:25 PM
Unknown Object (File)
Sun, Jul 12, 8:46 PM
Unknown Object (File)
Thu, Jul 9, 6:23 PM
Unknown Object (File)
Sun, Jul 5, 12:30 AM
Unknown Object (File)
Sat, Jul 4, 8:13 AM
Unknown Object (File)
Sat, Jul 4, 8:10 AM
Unknown Object (File)
Fri, Jul 3, 8:10 PM
Unknown Object (File)
Fri, Jul 3, 8:07 PM
View All Files
Subscribers
imp

Details

Reviewers
khng
kib
Commits
rGcd16a848d1b3: posixshmtest: Fix various warnings raised by GCC.
Summary
  • Remove unused format string arguments.
  • Remove a set but unused variable.

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

jhb created this revision.Sep 13 2021, 6:26 PM
Herald added a subscriber: imp. · View Herald TranscriptSep 13 2021, 6:26 PM
jhb requested review of this revision.Sep 13 2021, 6:26 PM
Harbormaster completed remote builds in B41500: Diff 95072.Sep 13 2021, 6:26 PM
kib accepted this revision.Sep 13 2021, 6:52 PM
kib added inline comments.
tests/sys/posixshm/posixshm_test.c
1108

Perhaps idea was to print out errno.

This revision is now accepted and ready to land.Sep 13 2021, 6:52 PM
khng accepted this revision.Sep 13 2021, 7:31 PM
jhb added inline comments.Sep 15 2021, 3:55 PM
tests/sys/posixshm/posixshm_test.c
1108

So I did that initially, but check_content_dealloc() doesn't always set errno when it fails, so I believe this was likely a copy-paste error.

Closed by commit rGcd16a848d1b3: posixshmtest: Fix various warnings raised by GCC. (authored by jhb). · Explain WhySep 15 2021, 4:06 PM
This revision was automatically updated to reflect the committed changes.
jhb added a commit: rGcd16a848d1b3: posixshmtest: Fix various warnings raised by GCC..

Revision Contents
Changeset List

PathSize
tests/
sys/
posixshm/
16 lines

Diff 95211

View Options

tests/sys/posixshm/posixshm_test.c

Loading...