Differential D31939

efitable: Don't pass NULL as a format string to xo_err().
ClosedPublic
Actions

Authored by jhb on Sep 13 2021, 6:21 PM.

Tags

None

Referenced Files

	Unknown Object (File)
	Fri, Dec 13, 7:31 AM

	Unknown Object (File)
	Mon, Nov 18, 8:36 AM

	Unknown Object (File)
	Mon, Nov 18, 8:33 AM

	Unknown Object (File)
	Mon, Nov 18, 6:39 AM

	Unknown Object (File)
	Oct 22 2024, 4:59 PM

	Unknown Object (File)
	Sep 27 2024, 4:21 PM

	Unknown Object (File)
	Sep 27 2024, 5:14 AM

	Unknown Object (File)
	Sep 26 2024, 1:47 PM

View All 66 Files

Subscribers

imp

Details

Reviewers

kib
emaste

Commits

rGb14cd3a8339e: efitable: Don't pass NULL as a format string to xo_err().

Summary

This fixes a -Wformat error reported by GCC 9.

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

jhb created this revision.Sep 13 2021, 6:21 PM

Herald added a subscriber: imp. · View Herald TranscriptSep 13 2021, 6:21 PM

jhb requested review of this revision.Sep 13 2021, 6:21 PM

Harbormaster completed remote builds in B41493: Diff 95065.Sep 13 2021, 6:21 PM

kib accepted this revision.Sep 13 2021, 6:54 PM

kib added inline comments.

usr.sbin/efitable/efitable.c
149	I suggest to add something like '(len == 0)' into the string, to distinguish two calls.

This revision is now accepted and ready to land.Sep 13 2021, 6:54 PM

jhb marked an inline comment as done.Sep 15 2021, 3:40 PM

Closed by commit rGb14cd3a8339e: efitable: Don't pass NULL as a format string to xo_err(). (authored by jhb). · Explain WhySep 15 2021, 4:06 PM

This revision was automatically updated to reflect the committed changes.

jhb added a commit: rGb14cd3a8339e: efitable: Don't pass NULL as a format string to xo_err()..

Revision Contents
Changeset List

Path

Size

usr.sbin/

efitable/

efitable.c

4 lines

Diff 95207

View Options

usr.sbin/efitable/efitable.c

efitable: Don't pass NULL as a format string to xo_err().ClosedPublicActions