Page MenuHomeFreeBSD

kernel: Disable errors for -Walloca-larger-than for GCC.

Authored by jhb on Mon, Sep 13, 6:10 PM.



GCC complains about the use of alloca() with variable sizes (for XSAVE
state len) in sendsig() for i386. Modern XSAVE state is probably
getting a bit large for the i386 kstack, but downgrade the error to a

Diff Detail

R10 FreeBSD src repository
Automatic diff as part of commit; lint not applicable.
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

jhb requested review of this revision.Mon, Sep 13, 6:10 PM

I opted for alloca() initially because the only alternative there I see is to have one more fpu save area allocated per-thread, realistically. It might be a reasonable way now, esp, if combined with the move of the user fpu save area from kstack.

This revision is now accepted and ready to land.Mon, Sep 13, 6:18 PM

Is it maybe worth adding a comment in sendsig along the lines of the above note?