Page MenuHomeFreeBSD

kernel: Disable errors for -Walloca-larger-than for GCC.
ClosedPublic

Authored by jhb on Sep 13 2021, 6:10 PM.
Tags
None
Referenced Files
Unknown Object (File)
Mar 19 2024, 8:34 AM
Unknown Object (File)
Feb 15 2024, 7:57 AM
Unknown Object (File)
Jan 18 2024, 1:16 PM
Unknown Object (File)
Jan 5 2024, 5:43 PM
Unknown Object (File)
Dec 20 2023, 3:16 AM
Unknown Object (File)
Dec 12 2023, 5:24 PM
Unknown Object (File)
Dec 3 2023, 10:46 PM
Unknown Object (File)
Sep 14 2023, 6:21 AM
Subscribers

Details

Summary

GCC complains about the use of alloca() with variable sizes (for XSAVE
state len) in sendsig() for i386. Modern XSAVE state is probably
getting a bit large for the i386 kstack, but downgrade the error to a
warning.

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

jhb requested review of this revision.Sep 13 2021, 6:10 PM

I opted for alloca() initially because the only alternative there I see is to have one more fpu save area allocated per-thread, realistically. It might be a reasonable way now, esp, if combined with the move of the user fpu save area from kstack.

This revision is now accepted and ready to land.Sep 13 2021, 6:18 PM

Is it maybe worth adding a comment in sendsig along the lines of the above note?