Page MenuHomeFreeBSD

kernel: Disable errors for -Walloca-larger-than for GCC.
ClosedPublic

Authored by jhb on Sep 13 2021, 6:10 PM.
Tags
None
Referenced Files
Unknown Object (File)
Sun, Jan 5, 7:24 AM
Unknown Object (File)
Nov 25 2024, 5:59 AM
Unknown Object (File)
Nov 19 2024, 12:07 PM
Unknown Object (File)
Nov 15 2024, 12:32 AM
Unknown Object (File)
Oct 26 2024, 5:14 AM
Unknown Object (File)
Oct 18 2024, 12:36 AM
Unknown Object (File)
Oct 16 2024, 12:59 PM
Unknown Object (File)
Oct 16 2024, 11:55 AM
Subscribers

Details

Summary

GCC complains about the use of alloca() with variable sizes (for XSAVE
state len) in sendsig() for i386. Modern XSAVE state is probably
getting a bit large for the i386 kstack, but downgrade the error to a
warning.

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

jhb requested review of this revision.Sep 13 2021, 6:10 PM

I opted for alloca() initially because the only alternative there I see is to have one more fpu save area allocated per-thread, realistically. It might be a reasonable way now, esp, if combined with the move of the user fpu save area from kstack.

This revision is now accepted and ready to land.Sep 13 2021, 6:18 PM

Is it maybe worth adding a comment in sendsig along the lines of the above note?