Page MenuHomeFreeBSD

kernel: Disable errors for -Walloca-larger-than for GCC.
ClosedPublic

Authored by jhb on Sep 13 2021, 6:10 PM.
Tags
None
Referenced Files
F170651755: D31934.id.diff
Sat, Sep 5, 8:00 PM
Unknown Object (File)
Fri, Sep 4, 12:28 AM
Unknown Object (File)
Thu, Sep 3, 5:01 AM
Unknown Object (File)
Tue, Sep 1, 1:43 PM
Unknown Object (File)
Tue, Sep 1, 1:20 PM
Unknown Object (File)
Tue, Sep 1, 4:00 AM
Unknown Object (File)
Sun, Aug 30, 11:33 AM
Unknown Object (File)
Sat, Aug 29, 7:00 PM
Subscribers

Details

Summary

GCC complains about the use of alloca() with variable sizes (for XSAVE
state len) in sendsig() for i386. Modern XSAVE state is probably
getting a bit large for the i386 kstack, but downgrade the error to a
warning.

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

jhb requested review of this revision.Sep 13 2021, 6:10 PM

I opted for alloca() initially because the only alternative there I see is to have one more fpu save area allocated per-thread, realistically. It might be a reasonable way now, esp, if combined with the move of the user fpu save area from kstack.

This revision is now accepted and ready to land.Sep 13 2021, 6:18 PM

Is it maybe worth adding a comment in sendsig along the lines of the above note?