Page MenuHomeFreeBSD

kernel: Disable errors for -Walloca-larger-than for GCC.
ClosedPublic

Authored by jhb on Sep 13 2021, 6:10 PM.
Tags
None
Referenced Files
F174508731: D31934.diff
Sat, Oct 3, 7:30 PM
Unknown Object (File)
Fri, Oct 2, 9:21 PM
Unknown Object (File)
Fri, Oct 2, 10:55 AM
Unknown Object (File)
Sat, Sep 19, 7:26 PM
Unknown Object (File)
Sat, Sep 19, 7:11 PM
Unknown Object (File)
Sat, Sep 19, 5:54 PM
Unknown Object (File)
Sun, Sep 6, 9:42 PM
Unknown Object (File)
Sun, Sep 6, 2:28 PM
Subscribers

Details

Summary

GCC complains about the use of alloca() with variable sizes (for XSAVE
state len) in sendsig() for i386. Modern XSAVE state is probably
getting a bit large for the i386 kstack, but downgrade the error to a
warning.

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

jhb requested review of this revision.Sep 13 2021, 6:10 PM

I opted for alloca() initially because the only alternative there I see is to have one more fpu save area allocated per-thread, realistically. It might be a reasonable way now, esp, if combined with the move of the user fpu save area from kstack.

This revision is now accepted and ready to land.Sep 13 2021, 6:18 PM

Is it maybe worth adding a comment in sendsig along the lines of the above note?