Page MenuHomeFreeBSD

kernel: Disable errors for -Walloca-larger-than for GCC.
ClosedPublic

Authored by jhb on Sep 13 2021, 6:10 PM.
Tags
None
Referenced Files
Unknown Object (File)
Thu, May 15, 4:35 PM
Unknown Object (File)
Tue, May 13, 4:33 PM
Unknown Object (File)
Tue, May 13, 2:33 PM
Unknown Object (File)
Tue, May 13, 1:58 PM
Unknown Object (File)
Mon, May 5, 10:56 PM
Unknown Object (File)
Apr 28 2025, 2:25 AM
Unknown Object (File)
Apr 27 2025, 9:28 PM
Unknown Object (File)
Apr 27 2025, 9:22 PM
Subscribers

Details

Summary

GCC complains about the use of alloca() with variable sizes (for XSAVE
state len) in sendsig() for i386. Modern XSAVE state is probably
getting a bit large for the i386 kstack, but downgrade the error to a
warning.

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

jhb requested review of this revision.Sep 13 2021, 6:10 PM

I opted for alloca() initially because the only alternative there I see is to have one more fpu save area allocated per-thread, realistically. It might be a reasonable way now, esp, if combined with the move of the user fpu save area from kstack.

This revision is now accepted and ready to land.Sep 13 2021, 6:18 PM

Is it maybe worth adding a comment in sendsig along the lines of the above note?