Page MenuHomeFreeBSD

multimedia/vlc: Enable support for subtitles by default and add missing deps
ClosedPublic

Authored by diizzy on Sep 6 2021, 12:44 PM.
Tags
None
Referenced Files
Unknown Object (File)
Sat, May 25, 2:05 PM
Unknown Object (File)
Thu, May 23, 6:20 PM
Unknown Object (File)
Apr 21 2024, 9:41 PM
Unknown Object (File)
Apr 17 2024, 11:53 AM
Unknown Object (File)
Apr 17 2024, 11:44 AM
Unknown Object (File)
Apr 17 2024, 11:44 AM
Unknown Object (File)
Apr 17 2024, 11:27 AM
Unknown Object (File)
Feb 2 2024, 6:49 AM
Subscribers
None

Diff Detail

Repository
R11 FreeBSD ports repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

diizzy created this revision.

Changes looks fine, although I'm bit unsure about --disable-mpg123 and iconv:wchar_t parts. Can you explain them?

By default the configure script will autodetect (lib)mpg123 (if available) which causes a dependency mismatch since it's not defined. As for functionality it's redundant because of ffmpeg and normally doesn't get pulled in. To be honest I don't know exactly what settings Philipp used but I can try to track it down however it's most likely due to a non standard option in some dependency.
Regarding iconv:wchar_t this was added in the patch Philipp submitted ( https://bugs.freebsd.org/bugzilla/attachment.cgi?id=226246 ) and grepping VLC's source code showed a few instances where it was used.

This revision is now accepted and ready to land.Sep 6 2021, 5:45 PM