Page MenuHomeFreeBSD

git-arc: allow word splitting in build_commit_list()
ClosedPublic

Authored by rew on Sep 4 2021, 7:49 PM.
Tags
None
Referenced Files
Unknown Object (File)
Fri, Jan 17, 8:27 AM
Unknown Object (File)
Dec 11 2024, 1:11 PM
Unknown Object (File)
Nov 27 2024, 3:30 AM
Unknown Object (File)
Nov 16 2024, 2:00 AM
Unknown Object (File)
Nov 12 2024, 1:50 AM
Unknown Object (File)
Nov 5 2024, 9:20 PM
Unknown Object (File)
Oct 3 2024, 10:35 AM
Unknown Object (File)
Sep 23 2024, 9:29 PM
Subscribers

Details

Summary

Allow word splitting and disable shellcheck SC2086 when using
git-rev-list to build the commit list.

Fixes: 4fd0c6ab1a9e ("Fix most shellcheck warnings in git-arc.sh")

After updating I started getting the following error when doing git arc list main..feature:

fatal: ambiguous argument 'b48029983aecdc79e14ac161b787a13172fe796a
^ba91e31f478aaade96bbdbf01560e8b7cbe41b56': unknown revision or path not in the working tree.
Use '--' to separate paths from revisions, like this:
'git <command> [<revision>...] -- [<file>...]'
git-arc: invalid commit ID main..feature

It seems that git-rev-list expects commits to be listed separately, this patch fixes the above error.

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable