Differential D31677

fspacectl(2): Changes on rmsr.r_offset's minimum value returned
ClosedPublic
Actions

Authored by khng on Aug 25 2021, 12:08 PM.

Tags

None

Referenced Files

	F148953886: D31677.diff
	Sat, Mar 21, 7:12 AM

	F148899469: D31677.diff
	Fri, Mar 20, 9:12 PM

	Unknown Object (File)
	Wed, Mar 18, 1:58 PM

	Unknown Object (File)
	Thu, Mar 12, 7:21 AM

	Unknown Object (File)
	Thu, Mar 12, 6:27 AM

	Unknown Object (File)
	Thu, Mar 12, 12:42 AM

	Unknown Object (File)
	Thu, Feb 19, 11:57 AM

	Unknown Object (File)
	Feb 18 2026, 7:05 AM

Subscribers

Details

Reviewers

Group Reviewers

Commits

rG9e202d036dd6: fspacectl(2): Changes on rmsr.r_offset's minimum value returned

Summary

rmsr.r_offset now is set to rqsr.r_offset plus the number of bytes
zeroed before hitting the end-of-file. After this change rmsr.r_offset
no longer contains the EOF when the requested operation range is
completely beyond the end-of-file. Instead in such case rmsr.r_offset is
equal to rqsr.r_offset. Callers can obtain the number of bytes zeroed
by subtracting rqsr.r_offset from rmsr.r_offset.

Sponsored by: The FreeBSD Foundation

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

khng created this revision.Aug 25 2021, 12:08 PM

Herald added a reviewer: manpages. · View Herald TranscriptAug 25 2021, 12:08 PM

Herald added a subscriber: imp. · View Herald Transcript

khng requested review of this revision.Aug 25 2021, 12:08 PM

Harbormaster completed remote builds in B41200: Diff 94163.Aug 25 2021, 12:08 PM

This should play better with the nfs_deallocate implementation in NFS4.2 client module.

kib accepted this revision.Aug 25 2021, 4:01 PM

This revision is now accepted and ready to land.Aug 25 2021, 4:01 PM

Closed by commit rG9e202d036dd6: fspacectl(2): Changes on rmsr.r_offset's minimum value returned (authored by khng). · Explain WhyAug 25 2021, 4:05 PM

This revision was automatically updated to reflect the committed changes.

khng added a commit: rG9e202d036dd6: fspacectl(2): Changes on rmsr.r_offset's minimum value returned.

Revision Contents
Changeset List

Path

Size

lib/

libc/

sys/

9 lines

share/

man/

man9/

VOP_DEALLOCATE.9

9 lines

vn_deallocate.9

7 lines

sys/

kern/

1 line

5 lines

Diff 94175

lib/libc/sys/fspacectl.2

Loading...

share/man/man9/VOP_DEALLOCATE.9

Loading...

share/man/man9/vn_deallocate.9

Loading...

sys/kern/uipc_shm.c

Loading...

sys/kern/vfs_default.c

Loading...