Page MenuHomeFreeBSD

routing: Fix crashes with dpdk_lpm algo.
ClosedPublic

Authored by melifaro on Aug 15 2021, 10:38 PM.
Tags
None
Referenced Files
Unknown Object (File)
Wed, Oct 8, 7:00 PM
Unknown Object (File)
Sat, Oct 4, 8:54 AM
Unknown Object (File)
Fri, Oct 3, 10:23 AM
Unknown Object (File)
Tue, Sep 30, 10:47 AM
Unknown Object (File)
Mon, Sep 29, 11:49 AM
Unknown Object (File)
Mon, Sep 29, 11:20 AM
Unknown Object (File)
Sat, Sep 27, 4:25 AM
Unknown Object (File)
Fri, Sep 26, 7:59 PM
Subscribers

Details

Summary

When a prefix gets deleted from the RIB, dpdk_lpm algo needs to know
the nexthop of the "parent" prefix to update its internal state.
The glue code, which utilises RIB as a backing route store, used
fib4_lookup_rt() after the prefix deletion. This approach didn't
work for "nested prefixes": if 10.0.0.0/24, 10.0.0.0/23 and 10.0.0.0/22
exists in RIB, deleting 10.0.0.0/23 resulted in 10.0.0.0/24 being
returned. This, in turn, resulted in failure to update the entire
/23 with a next nexhop, leading to eventual crashes.

Fix this by creating per-family rt_get_inet[6]_parent() helpers
and using them in the dpdk_lpm code.

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable