vt_core.c: Use do/while to highlight missed semi-colon errors
ClosedPublic
Actions

Authored by cem on Jul 22 2015, 5:44 PM.

Details

Reviewers

markj

Summary

(Style cleanup for r285794.)

Test Plan

It compiles with 'nodevice splash'.

Repository

rS FreeBSD src repository - subversion

Lint

Lint Passed

Unit

No Test Coverage

cem retitled this revision from to vt_core.c: Use do/while to highlight missed semi-colon errors.

cem updated this object.

cem edited the test plan for this revision. (Show Details)

cem added a reviewer: markj.

cem added a subscriber: jmg.

markj edited edge metadata.

markj added inline comments.

sys/dev/vt/vt_core.c
158	Phabricator might be hiding it, but there should be a tab after the #define.

This revision is now accepted and ready to land.Jul 22 2015, 6:27 PM

sys/dev/vt/vt_core.c
158	The existing convention in vt_core.c seems to be spaces between `#define`, name, and contents. I'm just following that. I can do a follow-up style(9) pass, if you like.

sys/dev/vt/vt_core.c
158	Only 13 out of 101 #defines in vt(4) use a space, so I'm not sure that's supposed to be the convention, but it's up to you. I think we try to avoid style(9) sweeps unless the code hasn't been touched in a long time or one is about to do some further work in the area.