Page MenuHomeFreeBSD

linux(4): Implement CLONE_CLEAR_SIGHAND option bit.
ClosedPublic

Authored by dchagin on Aug 9 2021, 7:53 PM.

Diff Detail

Repository
R10 FreeBSD src repository
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

Can you explain the semantic of CLEAR_SIGHAND, or provide a reference to the official doc?

sys/compat/linux/linux_fork.c
142

This leaves f2 uninitialize if CLEAR_SIGHAND is not specified, no?

fixed, CLONE_CLEAR_SIGHAND is designed to reset all signal handlers of the child
not set to SIG_IGN to SIG_DFL.

sys/compat/linux/linux_fork.c
154

Please do '|=' instead of '='.

kib added inline comments.
sys/compat/linux/linux_fork.c
142

I would also moved the initialization of ff there, from the declaration block.

This revision is now accepted and ready to land.Aug 10 2021, 9:44 AM