Details
- Reviewers
val_packett.cool - Commits
- R11:30bb70e94e1b: lang/crystal: fix broken base SSL usage
Diff Detail
- Repository
- R11 FreeBSD ports repository
- Lint
Lint Not Applicable - Unit
Tests Not Applicable
Event Timeline
If this is made into an extra-patch conditional on ${SSL_DEFAULT} == base, this could be applied until there's an upstream solution, I guess
- move hardcoded patches into EXTRA_PATCHES
- apply only when base ssl is required
- do substitution as required for various FreeBSD releases
- 14/CURRENT could conceivably change, but not clear what value to pick
If we're applying an extra-patch and then doing a REINPLACE_CMD, maybe we could just do a REINPLACE_CMD directly just against the 0.0.0 and the ldflags?
Also, you MUST NOT support ${OSVERSION} < 1200000! There's a clue as to why in the BOOTSTRAP_PATH variable ;)
Use OSREL:R for clarity, we don't require a specific kernel version, as
we don't require a specific kernel, just track FreeBSD version.
Yes I tried this earlier and in the end, a multi-line sed match just becomes unwieldy and messy.
These files are unlikely to be altered much, until we or upstream find a suitable permanent solution.
Also, you MUST NOT support ${OSVERSION} < 1200000! There's a clue as to why in the BOOTSTRAP_PATH variable ;)
fixed, thanks!
Patches work fine with the current version, just fix the distversion/portrevision conflict when rebasing