Page MenuHomeFreeBSD
Differential D31427

Add ElfW() macro for compatibility with Linux.
ClosedPublic
Actions

Authored by dim on Aug 5 2021, 7:00 PM.
Tags
None
Referenced Files
Unknown Object (File)
Tue, Aug 25, 9:53 AM
Unknown Object (File)
Thu, Aug 20, 6:00 AM
Unknown Object (File)
Sat, Aug 15, 11:13 AM
Unknown Object (File)
Wed, Aug 12, 10:53 PM
Unknown Object (File)
Wed, Aug 12, 8:40 PM
Unknown Object (File)
Tue, Aug 11, 4:35 AM
Unknown Object (File)
Mon, Aug 10, 12:12 PM
Unknown Object (File)
Mon, Aug 10, 12:08 PM
View All Files
Subscribers
imp

Details

Reviewers
emaste
kib
Commits
rG2b53701772f0: Add ElfW() macro for compatibility with Linux
rGb58a13b94c99: Add ElfW() macro for compatibility with Linux
rG6b364a92fd79: Add ElfW() macro for compatibility with Linux
rG34e7e4b6a059: Add ElfW() macro for compatibility with Linux
Summary

Some Linux software using ELF headers assumes the existence of an
ElfW(type) macro, which concatenates 'Elf', the default ELF word size,
and the given type. This is identical to our __ElfN(x) macro in
<sys/elf_generic.h>. Add the macro for compatibility.

Test Plan

maybe this needs an exp-run?

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

dim created this revision.Aug 5 2021, 7:00 PM
Herald added a subscriber: imp. · View Herald TranscriptAug 5 2021, 7:00 PM
dim requested review of this revision.Aug 5 2021, 7:00 PM
Harbormaster completed remote builds in B40872: Diff 93283.Aug 5 2021, 7:00 PM
emaste added a comment.Aug 5 2021, 8:36 PM

I think an exp-run is worthwhile

kib accepted this revision.Aug 5 2021, 10:22 PM
kib added inline comments.
sys/sys/elf_generic.h
60

I think some recommendation would be useful, like

.. with Linux, prefer __ElfN() in FreeBSD code */
This revision is now accepted and ready to land.Aug 5 2021, 10:22 PM
emaste accepted this revision.Aug 6 2021, 2:30 PM
Closed by commit rG34e7e4b6a059: Add ElfW() macro for compatibility with Linux (authored by dim). · Explain WhyAug 6 2021, 6:52 PM
This revision was automatically updated to reflect the committed changes.
dim added a commit: rG34e7e4b6a059: Add ElfW() macro for compatibility with Linux.
dim added a commit: rG6b364a92fd79: Add ElfW() macro for compatibility with Linux.Aug 14 2021, 1:04 PM
dim added a commit: rGb58a13b94c99: Add ElfW() macro for compatibility with Linux.
dim added a commit: rG2b53701772f0: Add ElfW() macro for compatibility with Linux.

Revision Contents
Changeset List

PathSize
sys/
sys/
3 lines

Diff 93334

View Options

sys/sys/elf_generic.h

Loading...