Page MenuHomeFreeBSD
Differential D31194

tcp: When rack or bbr get a pullup failure in the common code, don't free the NULL mbuf.
ClosedPublic
Actions

Authored by rrs on Jul 15 2021, 3:09 PM.
Tags
None
Referenced Files
Unknown Object (File)
Mon, May 18, 7:13 PM
Unknown Object (File)
Mon, May 18, 2:30 AM
Unknown Object (File)
Mon, May 18, 2:30 AM
Unknown Object (File)
Mon, May 18, 2:23 AM
Unknown Object (File)
Apr 21 2026, 2:04 PM
Unknown Object (File)
Apr 14 2026, 12:22 AM
Unknown Object (File)
Apr 11 2026, 11:40 PM
Unknown Object (File)
Apr 10 2026, 6:01 AM
View All Files
Subscribers
melifaro

Details

Reviewers
tuexen
Group Reviewers
transport
Commits
rGdb4d2d7222ee: tcp: When rack or bbr get a pullup failure in the common code, don't free the…
Summary

There is a bug in the error path where rack_bbr_common does a m_pullup() and the pullup fails.
There is a stray mfree(m) after m is set to NULL. This is not a good idea :-)

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Revision Contents
Changeset List

PathSize
sys/
netinet/
tcp_stacks/
2 lines

Diff 92287

View Options

sys/netinet/tcp_stacks/rack_bbr_common.c

Loading...