Page MenuHomeFreeBSD
Differential D31194

tcp: When rack or bbr get a pullup failure in the common code, don't free the NULL mbuf.
ClosedPublic
Actions

Authored by rrs on Jul 15 2021, 3:09 PM.
Tags
None
Referenced Files
Unknown Object (File)
Thu, Sep 17, 9:53 PM
Unknown Object (File)
Thu, Sep 17, 8:54 PM
Unknown Object (File)
Tue, Sep 15, 6:44 PM
Unknown Object (File)
Mon, Sep 7, 6:00 PM
Unknown Object (File)
Fri, Sep 4, 12:34 AM
Unknown Object (File)
Fri, Sep 4, 12:26 AM
Unknown Object (File)
Aug 12 2026, 9:17 PM
Unknown Object (File)
Aug 12 2026, 7:49 AM
View All Files
Subscribers
melifaro

Details

Reviewers
tuexen
Group Reviewers
transport
Commits
rGdb4d2d7222ee: tcp: When rack or bbr get a pullup failure in the common code, don't free the…
Summary

There is a bug in the error path where rack_bbr_common does a m_pullup() and the pullup fails.
There is a stray mfree(m) after m is set to NULL. This is not a good idea :-)

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Revision Contents
Changeset List

PathSize
sys/
netinet/
tcp_stacks/
2 lines

Diff 92287

View Options

sys/netinet/tcp_stacks/rack_bbr_common.c

Loading...