Page MenuHomeFreeBSD
Differential D31194

tcp: When rack or bbr get a pullup failure in the common code, don't free the NULL mbuf.
ClosedPublic
Actions

Authored by rrs on Jul 15 2021, 3:09 PM.
Tags
None
Referenced Files
Unknown Object (File)
Mon, Jan 5, 10:25 PM
Unknown Object (File)
Thu, Jan 1, 1:10 AM
Unknown Object (File)
Nov 25 2025, 11:52 PM
Unknown Object (File)
Nov 25 2025, 4:26 PM
Unknown Object (File)
Nov 24 2025, 4:39 AM
Unknown Object (File)
Nov 22 2025, 2:59 PM
Unknown Object (File)
Nov 15 2025, 11:03 PM
Unknown Object (File)
Oct 26 2025, 3:19 AM
View All 98 Files
Subscribers
melifaro

Details

Reviewers
tuexen
Group Reviewers
transport
Commits
rGdb4d2d7222ee: tcp: When rack or bbr get a pullup failure in the common code, don't free the…
Summary

There is a bug in the error path where rack_bbr_common does a m_pullup() and the pullup fails.
There is a stray mfree(m) after m is set to NULL. This is not a good idea :-)

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Revision Contents
Changeset List

PathSize
sys/
netinet/
tcp_stacks/
2 lines

Diff 92287

View Options

sys/netinet/tcp_stacks/rack_bbr_common.c

Loading...