Page MenuHomeFreeBSD
Differential D31194

tcp: When rack or bbr get a pullup failure in the common code, don't free the NULL mbuf.
ClosedPublic
Actions

Authored by rrs on Jul 15 2021, 3:09 PM.
Tags
None
Referenced Files
Unknown Object (File)
Sun, Jul 26, 11:57 AM
Unknown Object (File)
Tue, Jul 21, 11:28 AM
Unknown Object (File)
Tue, Jul 21, 12:31 AM
Unknown Object (File)
Tue, Jun 30, 9:06 AM
Unknown Object (File)
Jun 22 2026, 12:29 AM
Unknown Object (File)
May 18 2026, 7:13 PM
Unknown Object (File)
May 18 2026, 2:30 AM
Unknown Object (File)
May 18 2026, 2:30 AM
View All Files
Subscribers
melifaro

Details

Reviewers
tuexen
Group Reviewers
transport
Commits
rGdb4d2d7222ee: tcp: When rack or bbr get a pullup failure in the common code, don't free the…
Summary

There is a bug in the error path where rack_bbr_common does a m_pullup() and the pullup fails.
There is a stray mfree(m) after m is set to NULL. This is not a good idea :-)

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Revision Contents
Changeset List

PathSize
sys/
netinet/
tcp_stacks/
2 lines

Diff 92287

View Options

sys/netinet/tcp_stacks/rack_bbr_common.c

Loading...