Page MenuHomeFreeBSD

ffs: remove unused thread argument from ffs_reload()
ClosedPublic

Authored by rew on Jul 9 2021, 11:58 PM.
Tags
None
Referenced Files
F108637218: D31127.diff
Mon, Jan 27, 12:48 AM
Unknown Object (File)
Sat, Jan 18, 5:27 PM
Unknown Object (File)
Dec 17 2024, 9:20 PM
Unknown Object (File)
Dec 9 2024, 12:16 PM
Unknown Object (File)
Nov 1 2024, 3:49 AM
Unknown Object (File)
Oct 31 2024, 5:42 AM
Unknown Object (File)
Oct 14 2024, 8:18 PM
Unknown Object (File)
Oct 2 2024, 4:31 AM
Subscribers

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 40426
Build 37315: arc lint + arc unit

Event Timeline

rew requested review of this revision.Jul 9 2021, 11:58 PM
sys/ufs/ffs/ffs_vfsops.c
568

How do you know this is curthread here?

sys/ufs/ffs/ffs_vfsops.c
385

It gets assigned here

568

Before commit a92a971bbb94ad5b, vget() would assert that td == curthread.

In the above commit, the thread argument was dropped from vget().

vget() was the last consumer of the thread argument in ffs_reload(); curthread or the thread argument isn't referenced at all in ffs_reload().

imp added inline comments.
sys/ufs/ffs/ffs_vfsops.c
568

Then this looks good to me... I'd get kib or kirk to bless

This revision is now accepted and ready to land.Jul 10 2021, 1:33 AM