Page MenuHomeFreeBSD

ffs: remove unused thread argument from ffs_reload()
ClosedPublic

Authored by rew on Jul 9 2021, 11:58 PM.
Tags
None
Referenced Files
Unknown Object (File)
Jan 14 2024, 2:20 AM
Unknown Object (File)
Dec 22 2023, 9:40 PM
Unknown Object (File)
Sep 20 2023, 2:48 AM
Unknown Object (File)
Aug 20 2023, 9:59 PM
Unknown Object (File)
Aug 16 2023, 9:25 AM
Unknown Object (File)
Aug 16 2023, 6:15 AM
Unknown Object (File)
Aug 9 2023, 12:32 PM
Unknown Object (File)
May 7 2023, 9:48 PM
Subscribers

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

rew requested review of this revision.Jul 9 2021, 11:58 PM
sys/ufs/ffs/ffs_vfsops.c
541

How do you know this is curthread here?

sys/ufs/ffs/ffs_vfsops.c
358

It gets assigned here

541

Before commit a92a971bbb94ad5b, vget() would assert that td == curthread.

In the above commit, the thread argument was dropped from vget().

vget() was the last consumer of the thread argument in ffs_reload(); curthread or the thread argument isn't referenced at all in ffs_reload().

imp added inline comments.
sys/ufs/ffs/ffs_vfsops.c
541

Then this looks good to me... I'd get kib or kirk to bless

This revision is now accepted and ready to land.Jul 10 2021, 1:33 AM