Differential D31127

ffs: remove unused thread argument from ffs_reload()
ClosedPublic
Actions

Authored by rew on Jul 9 2021, 11:58 PM.

Tags

None

Referenced Files

	F161706746: D31127.id94670.diff
	Mon, Jul 6, 3:20 AM

	Unknown Object (File)
	Fri, Jul 3, 5:38 AM

	Unknown Object (File)
	Fri, Jul 3, 4:39 AM

	Unknown Object (File)
	Fri, Jun 12, 2:33 AM

	Unknown Object (File)
	Wed, Jun 10, 4:37 AM

	Unknown Object (File)
	Mon, Jun 8, 2:25 PM

	Unknown Object (File)
	May 18 2026, 1:29 AM

	Unknown Object (File)
	May 18 2026, 1:29 AM

Subscribers

Details

Reviewers

kib
imp

Commits

rG78a7d255e45d: ffs: remove unused thread argument from ffs_reload()
rG440320b620a2: ffs: remove unused thread argument from ffs_reload()

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

rew created this revision.Jul 9 2021, 11:58 PM

Herald added a subscriber: imp. · View Herald TranscriptJul 9 2021, 11:58 PM

rew requested review of this revision.Jul 9 2021, 11:58 PM

Harbormaster completed remote builds in B40426: Diff 92035.Jul 9 2021, 11:58 PM

rew added a reviewer: kib.Jul 10 2021, 12:00 AM

imp added inline comments.Jul 10 2021, 12:05 AM

sys/ufs/ffs/ffs_vfsops.c
541	How do you know this is curthread here?

rew added inline comments.Jul 10 2021, 1:03 AM

sys/ufs/ffs/ffs_vfsops.c
358	It gets assigned here
541	Before commit a92a971bbb94ad5b, vget() would assert that td == curthread. In the above commit, the thread argument was dropped from vget(). vget() was the last consumer of the thread argument in ffs_reload(); curthread or the thread argument isn't referenced at all in ffs_reload().

imp accepted this revision.Jul 10 2021, 1:33 AM

imp added inline comments.

sys/ufs/ffs/ffs_vfsops.c
541	Then this looks good to me... I'd get kib or kirk to bless

This revision is now accepted and ready to land.Jul 10 2021, 1:33 AM

kib accepted this revision.Jul 10 2021, 8:42 AM

Closed by commit rG440320b620a2: ffs: remove unused thread argument from ffs_reload() (authored by rew). · Explain WhySep 4 2021, 8:31 PM

This revision was automatically updated to reflect the committed changes.

rew added a commit: rG440320b620a2: ffs: remove unused thread argument from ffs_reload().

rew added a commit: rG78a7d255e45d: ffs: remove unused thread argument from ffs_reload().Sep 21 2021, 2:47 PM

Revision Contents
Changeset List

Path

Size

sys/

ufs/

ffs/

2 lines

2 lines

4 lines

Diff 94670

sys/ufs/ffs/ffs_extern.h

Loading...

sys/ufs/ffs/ffs_suspend.c

Loading...

sys/ufs/ffs/ffs_vfsops.c

Loading...