Fix to call callout_init with correct inputs from axp driver
ClosedPublic
Actions

Authored by rajeshasp on Jul 8 2021, 2:57 AM.

Tags

None

Referenced Files

	F166999047: D31104.id91959.diff
	Tue, Aug 18, 11:59 AM

	F166999028: D31104.id91959.diff
	Tue, Aug 18, 11:59 AM

	Unknown Object (File)
	Fri, Aug 14, 2:09 AM

	Unknown Object (File)
	Wed, Aug 12, 10:59 PM

	Unknown Object (File)
	Wed, Aug 12, 4:59 PM

	Unknown Object (File)
	Tue, Aug 11, 2:08 PM

	Unknown Object (File)
	Sun, Aug 9, 8:09 PM

	Unknown Object (File)
	Sun, Aug 9, 7:06 PM

View All Files

Subscribers

• hselasky

imp

Details

Reviewers

vmaffione
gallatin
• hselasky

Commits

rG0fd05b0173e2: Fix to call callout_init with correct inputs from axp driver

Summary

callout_init takes the second parameter as a flag to indicate MPSAFE.
axp(4) driver passes unwanted "hz" reference. This patch removes it.

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

rajeshasp created this revision.Jul 8 2021, 2:57 AM

Herald added a subscriber: imp. · View Herald TranscriptJul 8 2021, 2:57 AM

rajeshasp requested review of this revision.Jul 8 2021, 2:57 AM

Harbormaster completed remote builds in B40383: Diff 91959.Jul 8 2021, 2:57 AM

rajeshasp added a subscriber: • hselasky.Jul 8 2021, 3:06 AM

• hselasky accepted this revision.Jul 8 2021, 6:44 AM

This revision is now accepted and ready to land.Jul 8 2021, 6:44 AM

gallatin accepted this revision.Jul 8 2021, 8:03 PM

LGTM!

Closed by commit rG0fd05b0173e2: Fix to call callout_init with correct inputs from axp driver (authored by rajeshasp). · Explain WhyJul 13 2021, 2:40 PM

This revision was automatically updated to reflect the committed changes.

rajeshasp added a commit: rG0fd05b0173e2: Fix to call callout_init with correct inputs from axp driver.

Thanks everyone. Pushed upstream today. Sorry about the delay in pushing it.

Revision Contents
Changeset List

Path

Size

sys/

dev/

axgbe/

if_axgbe_pci.c

2 lines

Diff 92139

View Options

sys/dev/axgbe/if_axgbe_pci.c

Fix to call callout_init with correct inputs from axp driverClosedPublicActions