usr.bin/diff: fix UBSan error in readhash
ClosedPublic
Actions

Authored by arichardson on Jul 6 2021, 11:03 AM.

Details

Reviewers

bapt
kevans
imp

Commits

rG7a7324d9cebe: usr.bin/diff: fix UBSan error in readhash
rGc78f449d85e0: usr.bin/diff: fix UBSan error in readhash

Summary

UBSan complains about the sum = sum * 127 + chrtran(t); line below since
that can overflow an int. Use unsigned int instead to ensure that
overflow is well-defined.

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

arichardson created this revision.Jul 6 2021, 11:03 AM

Herald added a subscriber: imp. · View Herald TranscriptJul 6 2021, 11:03 AM

arichardson requested review of this revision.Jul 6 2021, 11:03 AM

Harbormaster completed remote builds in B40347: Diff 91872.Jul 6 2021, 11:03 AM

imp accepted this revision.Jul 6 2021, 11:15 AM

This revision is now accepted and ready to land.Jul 6 2021, 11:15 AM

Closed by commit rGc78f449d85e0: usr.bin/diff: fix UBSan error in readhash (authored by arichardson). · Explain WhyJul 6 2021, 1:30 PM

This revision was automatically updated to reflect the committed changes.

arichardson added a commit: rGc78f449d85e0: usr.bin/diff: fix UBSan error in readhash.

arichardson added a commit: rG7a7324d9cebe: usr.bin/diff: fix UBSan error in readhash.Aug 5 2021, 9:27 AM

Revision Contents
Changeset List

Path

Size

usr.bin/

diff/

diffreg.c

2 lines

Diff 91877

View Options

usr.bin/diff: fix UBSan error in readhashClosedPublicActions