Page MenuHomeFreeBSD

usr.bin/diff: fix UBSan error in readhash
ClosedPublic

Authored by arichardson on Jul 6 2021, 11:03 AM.
Tags
None
Referenced Files
F132238246: D31075.id91872.diff
Wed, Oct 15, 2:13 AM
F132238238: D31075.id91877.diff
Wed, Oct 15, 2:13 AM
F132238237: D31075.id.diff
Wed, Oct 15, 2:13 AM
F132198795: D31075.diff
Tue, Oct 14, 5:18 PM
Unknown Object (File)
Sun, Oct 12, 3:29 AM
Unknown Object (File)
Sun, Sep 21, 10:15 AM
Unknown Object (File)
Sep 8 2025, 12:49 PM
Unknown Object (File)
Jul 29 2025, 11:10 AM
Subscribers

Details

Summary

UBSan complains about the sum = sum * 127 + chrtran(t); line below since
that can overflow an int. Use unsigned int instead to ensure that
overflow is well-defined.

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable