Page MenuHomeFreeBSD

comms/gnuradio: update to 3.9.4.0
Needs ReviewPublic

Authored by vishwin on Jun 26 2021, 5:27 PM.

Details

Summary

Now flavourised like devel/git. DOCS option is gone; it takes up too much of the plist for minimal benefit.

Event: FreeBSD Developer Summit June 2021
Event: SouthEast LinuxFest 2021
Event: ARRL/RAC Field Day 2021
Event: Winter Field Day 2022

Test Plan

This is a call for testing (apart from my own dogfooding).

Requires newer devel/volk from D30700.

Diff Detail

Repository
rP FreeBSD ports repository
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 43722
Build 40610: arc lint + arc unit

Event Timeline

comms/gnuradio/Makefile
82

^+= really necessary here?

109

^ I think a new line between the different options might make it a bit more readable

127

instead of if-fery you could also use

GRC_VARS=INSTALLS_ICONS=yes

makes it a bit more concise.

diizzy added inline comments.
comms/gnuradio/Makefile
9–10

Define LICENSE_FILE?

12

Is this really needed?
We don't seem to do this with flavors in general

82
117

Some notes after Field Day dogfooding:

  • The FLAVORS setup complicates supporting consumers, particularly out-of-tree modules (as was the case with SoapySDR support before merged for 3.9.2.0). Consumers link to certain .sos that are provided by every flavour.
  • SoapySDR support may or may not have latency issues causing SIGBUS when running flowgraphs
  • Flowgraphs utilising real hardware via libusb must run as root until something is figured out
  • The GRC option seriously complicates providing a headless package, as most options also have GRC-specific files. This also precludes building GRC by itself from the subdirectory and packaging as such, as we don't have a way to validate option selection in dependencies.
comms/gnuradio/Makefile
12

Yes, because it is possible to have flavours that don't conflict

82

This CMakeFiles.txt seems to like overriding stuff we set in our framework.

comms/gnuradio/Makefile
82

That does not make any sense to me. You're passing it the same way to CMAKE_ARGS as cmake.mk is :) -- so as Daniel said, that should not be needed.

update to 3.9.4.0

Most tests and my flowgraphs still crashing. Also still trying to figure out how to "segregate" the GRC and QT5 options. May have to wait till subpackages become a reality, since everything can only be built together.

vishwin retitled this revision from comms/gnuradio: update to 3.9.2.0 to comms/gnuradio: update to 3.9.4.0.Jan 5 2022, 7:38 PM
vishwin edited the summary of this revision. (Show Details)

I updated port to 3.8.4 and my intention was to add a gnuradio-devel port since there are people still using both versions...
Does this sound sensible to all ?