Page MenuHomeFreeBSD

devel/volk: update to 2.5.0
AcceptedPublic

Authored by vishwin on Wed, Jun 9, 4:48 AM.

Details

Summary

This is intended to be used with comms/gnuradio 3.9, which I have WIP (almost ready for review/test) which I will most likely present during the WIP session at devsummit.

cpu_features is disabled because that upstream doesn't have code to support us (yet).

Test Plan

Passes testport, however the real test is with new comms/gnuradio. A wider call for testing will follow for that. This will only have a chance at landing when that port is ready.

Diff Detail

Repository
rP FreeBSD ports repository
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 39816
Build 36705: arc lint + arc unit

Event Timeline

Changes look fine. Did not build/run test this, though.

This revision is now accepted and ready to land.Wed, Jun 9, 5:35 AM

LGTM. Also, we need a new gnuradio asap for boost 1.76 landing :)

devel/volk/Makefile
9

LICENSE_FILE= should be defined

11

cpu_features seems to be https://www.freshports.org/devel/cpu_features/ but that doesn't work?

15

Should say python:3.6+ (we don't have 3.5 in tree anymore)

17

https://github.com/gnuradio/volk/releases/tag/v2.5.0 --> https://github.com/gnuradio/volk/releases/download/v2.5.0/volk-2.5.0.tar.xz
https://docs.freebsd.org/en/books/porters-handbook/makefiles/#makefile-categories --> 5.4.3
"If the distribution file comes from a specific commit or tag on GitHub for which there is no officially released file..." (use MASTER_SITES rather than USE_GITHUB)

devel/volk/Makefile
11

Ahh, https://github.com/google/cpu_features/issues/158
We should still try to use the port if possible though... ;-)

devel/volk/Makefile
11

No, they don't allow dynamically linking to it, plus the version required is newer than in ports.

11

No, they submoduled cpu_features for a reason. Not only is dynamic linking not allowed, but our port is too old.

11

It is not merged, plus looks like a no-op anyway.

17

They use github for their official distribution (and issue tracking and whatnot) now, especially when fetching source code, despite having their own cgit.

devel/volk/Makefile
17

My point was that you should use the tar.xz or tar.gz file (which are official release archives) instead of USE_GITHUB as that doesn't fetch assets.

Please have a look at this one: https://projects.pyret.net/files/public/freebsd/volk-prop.patch

  • Fixes Makefile ordering
  • Use upstream tar.xz archive
  • Update python:3.5+ to python:3.6+
  • Define LICENSE_FILE, TEST_TARGET
  • Import patch from openSUSE and follow their port

Ref: https://build.opensuse.org/package/show/openSUSE:Factory/volk

  • Import FreeBSD support from upstream pull request

Ref: https://github.com/google/cpu_features/pull/159

Compile and tested on 13.0-STABLE #0 stable/13-n245227-5ec4eb443e8 (amd64) (make, make check-plist, make test)

Looking further at that cpu_features upstream pull request, those sysctl values are probably wrong, and commented upstream to that effect.

And again, the real test is runtime with comms/gnuradio.

I just tried to rip out cpu_features (disabled) and make test fails

"23% tests passed, 104 tests failed out of 135"

Doesn't seem that promising :-/