Page MenuHomeFreeBSD

amd64: do not touch BIOS reset flag halfword, unless we boot through BIOS
ClosedPublic

Authored by kib on Jun 22 2021, 11:46 PM.

Diff Detail

Repository
rG FreeBSD src repository
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

kib requested review of this revision.Jun 22 2021, 11:46 PM
kib created this revision.
markj added inline comments.
sys/amd64/amd64/machdep.c
1182

I think it would be better to explicitly cast the address, i.e., (unsigned short *)0x472.

It seems like a strange place to do this operation. hammer_time() already checks for MODINFOMD_EFI_MAP to see if vty_set_preferred() should be called; we could do the same check earlier in order to set the BIOS flag, and perhaps save the result to avoid a second preload_search_info() call.

This revision is now accepted and ready to land.Jun 23 2021, 1:10 PM

Move the write to hammer_time()

This revision now requires review to proceed.Jun 23 2021, 8:01 PM
This revision is now accepted and ready to land.Jun 23 2021, 8:29 PM