Page MenuHomeFreeBSD
Differential D30806

Improved language in devmatch
ClosedPublic
Actions

Authored by ceri on Jun 17 2021, 6:28 PM.
Tags
None
Referenced Files
F81954307: D30806.id.diff
Tue, Apr 23, 5:03 PM
F81934396: D30806.id91052.diff
Tue, Apr 23, 10:27 AM
Unknown Object (File)
Mon, Apr 15, 5:33 PM
Unknown Object (File)
Mon, Apr 15, 5:15 PM
Unknown Object (File)
Mon, Apr 15, 5:01 PM
Unknown Object (File)
Mon, Apr 15, 4:59 PM
Unknown Object (File)
Mon, Apr 15, 4:54 PM
Unknown Object (File)
Wed, Apr 10, 11:25 AM
View All 46 Files
Subscribers
None

Details

Reviewers
imp
Commits
rG5df3b843fe31: devmatch: improve naming of devmatch config variable
rGf00dd44f0a24: devmatch: improve naming of devmatch config variable
rGc43b0081faab: devmatch: improve naming of devmatch config variable
Summary

Avoid the term "blacklist".
I have attempted not to break existing scripts, etc.

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

ceri requested review of this revision.Jun 17 2021, 6:28 PM
ceri updated this revision to Diff 91028.
ceri created this revision.

Remove style(9) stuff that crept in.

imp accepted this revision.Jun 17 2021, 9:33 PM

Change looks good to me:

  1. The new terminology is more descriptive
  2. The old variable is accepted when the new one isn't present (so backwards compatible)
  3. It's measured: it changes only what needs to change.
This revision is now accepted and ready to land.Jun 17 2021, 9:33 PM
Closed by commit rGc43b0081faab: devmatch: improve naming of devmatch config variable (authored by ceri). · Explain WhyJun 18 2021, 2:31 PM
This revision was automatically updated to reflect the committed changes.
ceri added a commit: rGc43b0081faab: devmatch: improve naming of devmatch config variable.
imp added a commit: rGf00dd44f0a24: devmatch: improve naming of devmatch config variable.Jul 8 2021, 10:26 PM
imp added a commit: rG5df3b843fe31: devmatch: improve naming of devmatch config variable.Jul 16 2021, 5:47 PM

Revision Contents
Changeset List

PathSize
libexec/
rc/
2 lines
rc.d/
4 lines
share/
man/
man5/
10 lines

Diff 91028

View Options

libexec/rc/rc.conf

Loading...
View Options

libexec/rc/rc.d/devmatch

Loading...
View Options

share/man/man5/rc.conf.5

Loading...