pipe_direct_write: Fix mismatched pipelock/unlock
ClosedPublic
Actions

Authored by cem on Jul 13 2015, 4:41 PM.

Details

Reviewers

kib
markj

Commits

rS285483: pipe_direct_write: Fix mismatched pipelock/unlock

Summary

If a signal is caught in pipelock, causing it to fail, pipe_direct_write should
not try to pipeunlock.

Reported by: pho
Sponsored by: EMC / Isilon Storage Division

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

cem updated this revision to Diff 6891.Jul 13 2015, 4:41 PM

cem retitled this revision from to pipe_direct_write: Fix mismatched pipelock/unlock.

cem updated this object.

cem edited the test plan for this revision. (Show Details)

cem added reviewers: markj, kib.

Herald added a subscriber: imp. · View Herald TranscriptJul 13 2015, 4:41 PM

kib accepted this revision.Jul 13 2015, 5:07 PM

kib edited edge metadata.

kib added inline comments.

sys/kern/sys_pipe.c
949 ↗	(On Diff #6891)	if (error != 0)
951 ↗	(On Diff #6891)	if ((wpipe->pipe_state & PIPE_EOF) != 0) {

This revision is now accepted and ready to land.Jul 13 2015, 5:07 PM

Fix style issues (thanks kib)

This revision now requires review to proceed.Jul 13 2015, 5:09 PM

Closed by commit rS285483: pipe_direct_write: Fix mismatched pipelock/unlock (authored by cem). · Explain WhyJul 13 2015, 5:45 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

head/

sys/

kern/

sys_pipe.c

5 lines

Diff 6895

View Options

pipe_direct_write: Fix mismatched pipelock/unlockClosedPublicActions