Page MenuHomeFreeBSD

security/pam-mysql: Update to 0.8.2
AcceptedPublic

Authored by jsm on Fri, Jun 4, 6:27 PM.

Details

Reviewers
koobs
Group Reviewers
Contributor Reviewers (ports)
Summary
security/pam-mysql: Update to 0.8.2

Old upstream is unmaintained and taken over by github.com/NigelCunningham/pam-MySQL

This version supports newer versions of MySQL and MariaDB, that do not define
make_scrambled_password().

Since pam now looks in LOCALBASE for modules change pkg-message accordingly

PR: 254731 
Reviewed_by: koobs (ports)
Differential_Revision: 30646
Test Plan

tested in poudriere and runtime briefly tested

Diff Detail

Repository
R11 FreeBSD ports repository
Lint
Lint Skipped
Unit
Unit Tests Skipped

Event Timeline

jsm requested review of this revision.Fri, Jun 4, 6:27 PM
jsm created this revision.
koobs added inline comments.
security/pam-mysql/Makefile
15

Empty line here (readability)

20

Update review SUMMARY to include proposed commit log message, including the 'why' for this chunk change. Is base pam stuff not needed any more? Is it broken?

28–30

Update review SUMMARY to include proposed commit log message, including the 'why' for this chunk change.

Does it no longer support ssl? Is it broken?

security/pam-mysql/pkg-descr
3

Is this the same upstream just moved, or a fork?

jsm edited the summary of this revision. (Show Details)

Readd option for openssl. and add --with-pam to make clear that it uses base pam, (but installs in LOCALBASE)

jsm marked 2 inline comments as done.Sat, Jun 5, 1:38 PM
tcberner added inline comments.
security/pam-mysql/Makefile
14–18

^ I would sort USES alphabetically -- makes it easier to parse quickly by eye.

jsm marked an inline comment as done.Sat, Jun 5, 2:21 PM
koobs edited the summary of this revision. (Show Details)

Looks good. Approved if it passes QA for different values of USES=ssl (base, ssl, libre), otherwise add blocks to BROKEN, or IGNORE them, or report issues accordingly

security/pam-mysql/Makefile
9

s/Pam/PAM

This revision is now accepted and ready to land.Sun, Jun 6, 12:24 AM