Page MenuHomeFreeBSD

riscv: Rename pmap_fault_fixup() to pmap_fault()
ClosedPublic

Authored by markj on Fri, Jun 4, 6:22 PM.

Details

Summary

This is consistent with other platforms, specifically arm and arm64,
which use it to implement software management of accessed and dirty
bits.

No functional change intended.

Diff Detail

Repository
R10 FreeBSD src repository
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

I guess it got copied from arm's pmap-v4 (you can still find references that function for it in the tree)?

This revision is now accepted and ready to land.Fri, Jun 4, 6:53 PM

I guess it got copied from arm's pmap-v4 (you can still find references that function for it in the tree)?

Ah, I see. Looks like last_fault_code can be removed then.

Regarding the overall change, I don't have a strong preference for it, it would just be nice to be consistent especially now that pmap-v4.c is gone.

I guess it got copied from arm's pmap-v4 (you can still find references that function for it in the tree)?

Ah, I see. Looks like last_fault_code can be removed then.

Regarding the overall change, I don't have a strong preference for it, it would just be nice to be consistent especially now that pmap-v4.c is gone.

Yeah, seems sensible. I quite liked the "fixup" in the name, but best to align with pmap-v6 and arm64.