Page MenuHomeFreeBSD
Differential D30525

aic7xxx: Fix re-building firmware with -fno-common
ClosedPublic
Actions

Authored by jrtc27 on May 28 2021, 2:34 PM.
Tags
None
Referenced Files
Unknown Object (File)
Wed, Apr 24, 11:53 AM
Unknown Object (File)
Tue, Apr 23, 3:40 AM
Unknown Object (File)
Mon, Apr 22, 8:55 AM
Unknown Object (File)
Tue, Apr 9, 2:16 PM
Unknown Object (File)
Feb 21 2024, 2:19 PM
Unknown Object (File)
Jan 26 2024, 8:53 PM
Unknown Object (File)
Dec 28 2023, 11:39 PM
Unknown Object (File)
Dec 23 2023, 7:32 PM
View All 28 Files
Subscribers
imp
Contributor Reviews (src)

Details

Reviewers
kevans
imp
Commits
rGb305e1dfbf69: aic7xxx: Fix re-building firmware with -fno-common
rG5e478926f04a: aic7xxx: Fix re-building firmware with -fno-common
rG36da5710d3e4: aic7xxx: Fix re-building firmware with -fno-common
rG5e912f5fec02: aic7xxx: Fix re-building firmware with -fno-common
Summary

MFC after: 1 week

Test Plan

Ran make firmware on FreeBSD 13

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 39537
Build 36426: arc lint + arc unit

Event Timeline

jrtc27 created this revision.May 28 2021, 2:34 PM
Herald added subscribers: Contributor Reviews (src), imp. · View Herald TranscriptMay 28 2021, 2:34 PM
jrtc27 requested review of this revision.May 28 2021, 2:34 PM
Harbormaster completed remote builds in B39537: Diff 90058.May 28 2021, 2:34 PM
jrtc27 added reviewers: kevans, imp.May 28 2021, 2:45 PM
imp accepted this revision.May 28 2021, 3:57 PM
This revision is now accepted and ready to land.May 28 2021, 3:57 PM
imp added inline comments.May 28 2021, 4:02 PM
sys/dev/aic7xxx/aicasm/aicasm_gram.y
62

Once upon a time, this was defined in -ll.... Is that no longer the case? Or are we just not linking against that? If we're not, then this is likely the most correct fix.

jrtc27 added inline comments.May 28 2021, 4:13 PM
sys/dev/aic7xxx/aicasm/aicasm_gram.y
62

lex itself injects the definition into the output, in this case for aicasm_scan.l's generated C. No extra libraries are linked in, only libc etc.

Closed by commit rG5e912f5fec02: aic7xxx: Fix re-building firmware with -fno-common (authored by jrtc27). · Explain WhyMay 28 2021, 6:15 PM
This revision was automatically updated to reflect the committed changes.
jrtc27 added a commit: rG5e912f5fec02: aic7xxx: Fix re-building firmware with -fno-common.
jrtc27 added a commit: rG36da5710d3e4: aic7xxx: Fix re-building firmware with -fno-common.Jun 4 2021, 12:29 AM
jrtc27 added a commit: rG5e478926f04a: aic7xxx: Fix re-building firmware with -fno-common.
jrtc27 added a commit: rGb305e1dfbf69: aic7xxx: Fix re-building firmware with -fno-common.

Revision Contents
Changeset List

PathSize
sys/
dev/
aic7xxx/
aicasm/
2 lines
2 lines

Diff 90058

View Options

sys/dev/aic7xxx/aicasm/aicasm_gram.y

Loading...
View Options

sys/dev/aic7xxx/aicasm/aicasm_symbol.h

Loading...