Don't panic on opening a GEOM node with O_EXEC.
ClosedPublic
Actions

Authored by trasz on Jul 11 2015, 11:37 AM.

Details

Reviewers

kib
mav

Commits

rS286283: Fix panic triggered by code like this:

Summary

Fix panic triggered by code like this:

open("/dev/md0", O_EXEC);

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

trasz updated this revision to Diff 6857.Jul 11 2015, 11:37 AM

trasz retitled this revision from to Don't panic on opening a GEOM node with O_EXEC..

trasz updated this object.

trasz edited the test plan for this revision. (Show Details)

Herald added a subscriber: imp. · View Herald TranscriptJul 11 2015, 11:37 AM

trasz added a reviewer: mav.Jul 11 2015, 11:38 AM

Same as for close, I am not sure it is proper place to check it here. May be we are incorrectly handling some POSIX flags semantics when handling open syscall.

You mean, move the check up a layer, eg into devfs?

Konstantin, what do you think? Leave it here, or move to eg devfs?

If we are sure that no devfs nodes should be opened with O_EXEC, then devfs would be reasonable place for the check. Otherwise, geom, which cannot handle the request, should plug the case.

I cannot provide an easy example for the O_EXEC open of the devfs node. Might be, in-place execution from ROM is the suitable use case. If so, your patch is fine.

Closed by commit rS286283: Fix panic triggered by code like this: (authored by trasz). · Explain WhyAug 4 2015, 10:40 AM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

head/

sys/

geom/

geom_dev.c

7 lines

Diff 7648

View Options

Don't panic on opening a GEOM node with O_EXEC.ClosedPublicActions