Paths

Table of Contentst

Differential D30425

LinuxKPI: add ether_addr_equal_unaligned()
ClosedPublic
Actions

Authored by bz on May 24 2021, 6:23 PM.

Tags

None

Referenced Files

	Unknown Object (File)
	Wed, Apr 15, 5:19 PM

	Unknown Object (File)
	Mon, Apr 6, 8:36 PM

	Unknown Object (File)
	Mon, Apr 6, 2:01 PM

	Unknown Object (File)
	Mon, Apr 6, 5:33 AM

	Unknown Object (File)
	Mon, Apr 6, 3:25 AM

	Unknown Object (File)
	Sun, Apr 5, 6:15 PM

	Unknown Object (File)
	Sun, Apr 5, 12:23 PM

	Unknown Object (File)
	Sun, Apr 5, 9:19 AM

Subscribers

Details

Reviewers

Group Reviewers

Commits

rG9af6ce636839: LinuxKPI: add ether_addr_equal_unaligned()
rG834227ba6e80: LinuxKPI: add ether_addr_equal_unaligned()

Summary

Add a #define for ether_addr_equal_unaligned() founf in wireless
drivers. ether_addr_equal() already uses memcmp() so we should be
fine for unaligned accessed.

Sponsored by: The FreeBSD Foundation
MFC after: 2 weeks
Reviewed by:
Differential Revision:

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

bz created this revision.May 24 2021, 6:23 PM

Herald added subscribers: emaste, imp. · View Herald TranscriptMay 24 2021, 6:23 PM

bz requested review of this revision.May 24 2021, 6:23 PM

Harbormaster completed remote builds in B39394: Diff 89749.May 24 2021, 6:23 PM

founf -> found

Should we do this the other way, making ether_addr_equal_unaligned the inline fn and ether_addr_equal a #define, so that ether_addr_equal can't be accidentally broken?

• hselasky added a subscriber: • hselasky.May 24 2021, 7:24 PM

• hselasky added inline comments.

sys/compat/linuxkpi/common/include/linux/etherdevice.h
89	Too many parenthesis (not needed here)! ((_pa), (_pb)) -> (_pa, _pb)

Switch the implementation and define as suggested by @emaste.
Revmove extra () as pointed out by @hselasky.

Harbormaster completed remote builds in B39418: Diff 89780.May 24 2021, 9:39 PM

bz marked an inline comment as done.May 24 2021, 9:39 PM

• hselasky accepted this revision.May 25 2021, 7:39 AM

This revision is now accepted and ready to land.May 25 2021, 7:39 AM

Closed by commit rG834227ba6e80: LinuxKPI: add ether_addr_equal_unaligned() (authored by bz). · Explain WhyMay 25 2021, 6:16 PM

This revision was automatically updated to reflect the committed changes.

bz added a commit: rG834227ba6e80: LinuxKPI: add ether_addr_equal_unaligned().

bz added a commit: rG9af6ce636839: LinuxKPI: add ether_addr_equal_unaligned().Jul 18 2021, 12:38 AM

Revision Contents
Changeset List

Path

Size

sys/

compat/

linuxkpi/

common/

include/

linux/

3 lines

Diff 89853

sys/compat/linuxkpi/common/include/linux/etherdevice.h

Loading...