Differential D30347

pfctl: Ensure parent queue is configured for FAIRQ
ClosedPublic
Actions

Authored by kp on May 19 2021, 12:00 PM.

Tags

None

Referenced Files

	Unknown Object (File)
	Fri, Nov 21, 6:27 PM

	Unknown Object (File)
	Fri, Nov 7, 12:28 AM

	Unknown Object (File)
	Wed, Nov 5, 3:05 AM

	Unknown Object (File)
	Nov 1 2025, 10:20 AM

	Unknown Object (File)
	Oct 26 2025, 7:27 PM

	Unknown Object (File)
	Oct 25 2025, 11:11 PM

	Unknown Object (File)
	Oct 21 2025, 3:44 AM

	Unknown Object (File)
	Oct 10 2025, 2:28 PM

Subscribers

Details

Reviewers

None

Group Reviewers

Commits

rG47a3d57efdb8: pfctl: Ensure parent queue is configured for FAIRQ
rGc5bc18c83645: pfctl: Ensure parent queue is configured for FAIRQ
rGdc784287967d: pfctl: Ensure parent queue is configured for FAIRQ

Summary

We failed to account for the FAIRQ scheduler in expand_altq(), which led
it to be set up without its parent queue.

MFC after: 1 week
Sponsored by: Rubicon Communications, LLC ("Netgate")

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

kp created this revision.May 19 2021, 12:00 PM

Herald added a subscriber: imp. · View Herald TranscriptMay 19 2021, 12:00 PM

kp requested review of this revision.May 19 2021, 12:00 PM

Harbormaster completed remote builds in B39290: Diff 89469.May 19 2021, 12:00 PM

kp added a parent revision: D30346: pfctl: Fix crash on ALTQ configuration.May 19 2021, 12:01 PM

kp added a child revision: D30348: pfctl tests: Test fairq configuration.

This revision was not accepted when it landed; it landed in state Needs Review.May 20 2021, 12:07 PM

Closed by commit rGdc784287967d: pfctl: Ensure parent queue is configured for FAIRQ (authored by kp). · Explain Why

This revision was automatically updated to reflect the committed changes.

kp added a commit: rGdc784287967d: pfctl: Ensure parent queue is configured for FAIRQ.

kp added a commit: rGc5bc18c83645: pfctl: Ensure parent queue is configured for FAIRQ.May 27 2021, 10:20 AM

kp added a commit: rG47a3d57efdb8: pfctl: Ensure parent queue is configured for FAIRQ.

Revision Contents
Changeset List

Path

Size

sbin/

pfctl/

6 lines

Diff 89528

sbin/pfctl/parse.y

Loading...