Page MenuHomeFreeBSD
Differential D30252

acct: Reset the thread rlimits on exit
AbandonedPublic
Actions

Authored by markj on May 13 2021, 8:37 PM.
Tags
None
Referenced Files
Unknown Object (File)
Tue, May 12, 11:43 AM
Unknown Object (File)
Thu, May 7, 12:46 PM
Unknown Object (File)
Sat, May 2, 12:35 PM
Unknown Object (File)
Mon, Apr 20, 10:30 AM
Unknown Object (File)
Apr 16 2026, 11:01 PM
Unknown Object (File)
Apr 16 2026, 2:53 AM
Unknown Object (File)
Apr 6 2026, 1:44 PM
Unknown Object (File)
Mar 28 2026, 11:22 AM
View All 74 Files
Subscribers
imp

Details

Reviewers
kib
mjg
Summary

acct_process() resets the resource limits in exiting process, mostly to
ensure that a file size limit does not inhibit writing to the accounting
record file configured with acct(2). But since we started caching
limits in threads, we need to reset that pointer too.

Noticed while investigating a syzkaller bug.

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 39173
Build 36062: arc lint + arc unit

Event Timeline

markj created this revision.May 13 2021, 8:37 PM
Herald added a subscriber: imp. · View Herald TranscriptMay 13 2021, 8:37 PM
markj requested review of this revision.May 13 2021, 8:37 PM
Harbormaster completed remote builds in B39173: Diff 89162.May 13 2021, 8:37 PM
kib added a comment.May 13 2021, 11:58 PM

I dislike this hack with replacing p_limit/td_limit. We have the file size limit check done in vn_file_size(), so it is easy to avoid the limit check when not needed. Please see D30257

markj abandoned this revision.May 14 2021, 1:35 AM

Revision Contents
Changeset List

PathSize
sys/
kern/
4 lines

Diff 89162

View Options

sys/kern/kern_acct.c

Loading...