makesyscalls.lua: improve generated file style(9) compliance
ClosedPublic
Actions

Authored by emaste on May 12 2021, 8:23 PM.

Details

Reviewers

kevans
brooks

Commits

rG0bd5d81f1edf: makesyscalls.lua: improve generated file style(9) compliance
rGad385f7b46e7: makesyscalls.lua: improve generated file style(9) compliance

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

emaste requested review of this revision.May 12 2021, 8:23 PM

emaste created this revision.

one more missing space in __CONCAT macro use

kevans added inline comments.May 13 2021, 1:19 PM

sys/tools/makesyscalls.lua
1312	Tab after `#define`
1319	Ditto, and for the `#else #define`

oh, i don't feel that strongly about those- feel free to ignore. :-)

I think I'm going to look at rewriting/refactoring makesyscalls.lua with an eye towards making it lib-ish so that it could be used for "other reasons" to process and work with syscall definitions.

This revision is now accepted and ready to land.May 13 2021, 1:23 PM

brooks accepted this revision.May 13 2021, 5:43 PM

emaste added inline comments.May 13 2021, 5:57 PM

sys/tools/makesyscalls.lua
1312	Despite style(9) it seems `#define<space>` is a lot more common in sys/, and clang-format does the same so I plan to leave these two unchanged for now.