Page MenuHomeFreeBSD
Differential D30223

audio/alsa-plugins: fix non-default OPTIONS
ClosedPublic
Actions

Authored by vishwin on May 12 2021, 4:00 AM.
Tags
None
Referenced Files
Unknown Object (File)
Wed, Apr 17, 5:26 AM
Unknown Object (File)
Tue, Apr 16, 4:23 PM
Unknown Object (File)
Sat, Apr 13, 8:40 PM
Unknown Object (File)
Sat, Apr 13, 8:39 PM
Unknown Object (File)
Sat, Apr 13, 8:31 PM
Unknown Object (File)
Tue, Apr 9, 2:13 PM
Unknown Object (File)
Sun, Apr 7, 4:32 PM
Unknown Object (File)
Thu, Apr 4, 9:12 PM
View All 64 Files
Subscribers
mat

Details

Reviewers
tcberner
fluffy
arrowd
Commits
R11:933747467c06: audio/alsa-plugins: fix non-default OPTIONS
Summary
  • Remove FFMPEG as the relevant configure option is gone
  • Add two missing files with SAMPLERATE

Approved by: ? (mentor)
PR: 245321

Test Plan

Passes bulk -t.

Diff Detail

Repository
rP FreeBSD ports repository
Lint
No Lint Coverage
Unit
No Test Coverage
Build Status
Buildable 39134
Build 36023: arc lint + arc unit

Event Timeline

vishwin created this revision.May 12 2021, 4:00 AM
Herald added a subscriber: mat. · View Herald TranscriptMay 12 2021, 4:00 AM
vishwin requested review of this revision.May 12 2021, 4:00 AM
Harbormaster completed remote builds in B39134: Diff 89059.May 12 2021, 4:00 AM
arrowd added a comment.May 12 2021, 5:40 AM

It seems, the option is now called --disable-libav and we should always add it unless FFMPEG option is set. The same goes for other options.

Can you do that? Thanks in advance.

vishwin updated this revision to Diff 89071.May 12 2021, 2:24 PM

resurrect FFMPEG, configure option changed

Harbormaster completed remote builds in B39140: Diff 89071.May 12 2021, 2:24 PM
arrowd accepted this revision.May 12 2021, 2:28 PM

Thanks for fixing this.

This revision is now accepted and ready to land.May 12 2021, 2:28 PM
Closed by commit R11:933747467c06: audio/alsa-plugins: fix non-default OPTIONS (authored by vishwin). · Explain WhyMay 12 2021, 2:41 PM
This revision was automatically updated to reflect the committed changes.
vishwin added a commit: R11:933747467c06: audio/alsa-plugins: fix non-default OPTIONS.

Revision Contents
Changeset List

PathSize
audio/
alsa-plugins/
5 lines
10 lines

Diff 89059

View Options

audio/alsa-plugins/Makefile

Loading...
View Options

audio/alsa-plugins/pkg-plist

Loading...