vfs: Fix error handling in vn_fullpath_hardlink()
ClosedPublic
Actions

Authored by markj on May 10 2021, 8:35 PM.

Details

Reviewers

kib
mjg

Commits

rG8b59c6af27d1: vfs: Fix error handling in vn_fullpath_hardlink()
rGc8bbb1272c8b: vfs: Fix error handling in vn_fullpath_hardlink()

Summary

vn_fullpath_any_smr() will return a positive error number if the
caller-supplied buffer isn't big enough. In this case the error must be
propagated up, otherwise we may copy out uninitialized bytes.

Reported by: syzkaller+KMSAN

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

markj created this revision.May 10 2021, 8:35 PM

Herald added a subscriber: imp. · View Herald TranscriptMay 10 2021, 8:35 PM

markj requested review of this revision.May 10 2021, 8:35 PM

Harbormaster completed remote builds in B39110: Diff 88988.May 10 2021, 8:35 PM

mjg accepted this revision.May 10 2021, 8:40 PM

This revision is now accepted and ready to land.May 10 2021, 8:40 PM

kib accepted this revision.May 10 2021, 9:32 PM

Closed by commit rGc8bbb1272c8b: vfs: Fix error handling in vn_fullpath_hardlink() (authored by markj). · Explain WhyMay 11 2021, 12:26 AM

This revision was automatically updated to reflect the committed changes.

markj added a commit: rGc8bbb1272c8b: vfs: Fix error handling in vn_fullpath_hardlink().

mjg added a commit: rG8b59c6af27d1: vfs: Fix error handling in vn_fullpath_hardlink().May 22 2021, 6:34 PM

Revision Contents
Changeset List

Path

Size

sys/

kern/

vfs_cache.c

4 lines

Diff 88993

View Options

vfs: Fix error handling in vn_fullpath_hardlink()ClosedPublicActions