Paths

Table of Contentst

Differential D30042

traceroute6: Properly calculate UDP checksum
ClosedPublic
Actions

Authored by zlei on Apr 30 2021, 9:14 AM.

Tags

None

Referenced Files

	Unknown Object (File)
	Fri, Mar 27, 7:21 AM

	Unknown Object (File)
	Thu, Mar 26, 5:19 PM

	Unknown Object (File)
	Sun, Mar 22, 5:58 PM

	Unknown Object (File)
	Sun, Mar 22, 2:15 AM

	Unknown Object (File)
	Fri, Mar 20, 5:35 AM

	Unknown Object (File)
	Thu, Mar 19, 7:50 AM

	Unknown Object (File)
	Thu, Mar 19, 7:42 AM

	Unknown Object (File)
	Tue, Mar 17, 2:21 AM

Subscribers

None

Details

Reviewers

markj
tuexen
ae

Commits

rGe183dd501caf: traceroute6: Properly calculate UDP checksum
rG1d712c05370d: traceroute6: Properly calculate UDP checksum

Summary

The revision D25604 capsicumize traceroute6. For UDP the send socket was changed from SOCK_DGRAM to SOCK_RAW and thus the UDP checksum need be calculated by application itself other than the kernel.

outpacket is filled with zeros by line 707, thus the first round the UDP checksum is correct. But subsequent rounds outudp->uh_sum will be left with garbage.

Test Plan

host A <----> Router <----> host B

traceroute6 hostB
netstat -sp udp | grep 'bad checksum'

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

zlei requested review of this revision.Apr 30 2021, 9:14 AM

zlei created this revision.

tuexen accepted this revision.Apr 30 2021, 9:20 AM

This revision is now accepted and ready to land.Apr 30 2021, 9:20 AM

zlei edited the summary of this revision. (Show Details)Apr 30 2021, 9:22 AM

ae accepted this revision.Apr 30 2021, 10:33 AM

markj accepted this revision.Apr 30 2021, 1:31 PM

Closed by commit rG1d712c05370d: traceroute6: Properly calculate UDP checksum (authored by zlei, committed by markj). · Explain WhyMay 3 2021, 5:56 PM

This revision was automatically updated to reflect the committed changes.

markj added a commit: rG1d712c05370d: traceroute6: Properly calculate UDP checksum.

markj added a commit: rGe183dd501caf: traceroute6: Properly calculate UDP checksum.May 6 2021, 1:01 PM

Revision Contents
Changeset List

Path

Size

usr.sbin/

traceroute6/

1 line

Diff 88565

usr.sbin/traceroute6/traceroute6.c

Loading...