Page MenuHomeFreeBSD

[rtsock] Enforce netmask/RTF_HOST consistency
ClosedPublic

Authored by melifaro on Apr 23 2021, 9:54 PM.
Tags
None
Referenced Files
Unknown Object (File)
Mon, Sep 7, 4:36 PM
Unknown Object (File)
Mon, Sep 7, 12:58 PM
Unknown Object (File)
Sun, Sep 6, 4:40 AM
Unknown Object (File)
Sat, Sep 5, 6:01 PM
Unknown Object (File)
Fri, Sep 4, 8:02 AM
Unknown Object (File)
Thu, Sep 3, 4:09 PM
Unknown Object (File)
Tue, Sep 1, 11:34 PM
Unknown Object (File)
Tue, Sep 1, 11:21 PM
Subscribers

Details

Summary

Traditionally we had 2 sources of information whether the added/delete route request targets network or a host route:
netmask (RTA_NETMASK) and RTF_HOST flag.

The former one is tricky: netmask can be empty or can explicitly specify the host netmask. Parsing netmask sockaddr requires per-family parsing and that's what rtsock code traditionally avoided. As a result, consistency was not enforced and it was possible to specify network with the RTF_HOST flag and vice versa.

Continue normalization efforts from D29826 and D29826 and ensure that RTF_HOST flag always reflects host/network data from netmask field.

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable