Page MenuHomeFreeBSD

libkiconv: address memory leak in a not-found case
ClosedPublic

Authored by emaste on Apr 21 2021, 5:48 PM.

Diff Detail

Repository
rG FreeBSD src repository
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

emaste created this revision.
scottl requested changes to this revision.Apr 21 2021, 5:59 PM
scottl added a subscriber: scottl.
scottl added inline comments.
lib/libkiconv/kiconv_sysctl.c
89

Do you mean free(csi) here?

This revision now requires changes to proceed.Apr 21 2021, 5:59 PM
jhb added a subscriber: jhb.

RAII would be nice.

This revision was not accepted when it landed; it landed in state Needs Review.Apr 22 2021, 11:34 PM
This revision was automatically updated to reflect the committed changes.