Page MenuHomeFreeBSD

Mk/Uses/cabal.mk: Replace shell process in wrapper scripts
ClosedPublic

Authored by tobik on Apr 20 2021, 5:34 AM.
Tags
None
Referenced Files
Unknown Object (File)
Mon, Jul 28, 4:42 AM
Unknown Object (File)
Sun, Jul 20, 8:32 AM
Unknown Object (File)
Jun 17 2025, 3:22 AM
Unknown Object (File)
May 29 2025, 8:10 PM
Unknown Object (File)
May 23 2025, 3:37 PM
Unknown Object (File)
May 16 2025, 12:32 AM
Unknown Object (File)
May 12 2025, 2:57 AM
Unknown Object (File)
May 11 2025, 8:43 PM
Subscribers

Details

Summary
  • The wrapper scripts leave the shell running for no reason. Add an exec to replace the shell process
  • While here use ECHO_CMD not ECHO (ECHO is set to true on make -s in /usr/share/mk/sys.mk and shouldn't be used for things like this)

    Before:
$ ps -d
35230  5  Ss    0:00.09 -oksh (oksh)
35351  5  S+    0:00.00 - /bin/sh /usr/local/bin/shellcheck -
35352  5  S+    0:00.00 `-- /usr/local/libexec/cabal/shellcheck -

After:

$ ps -d
35230  5  Is    0:00.05 -oksh (oksh)
35236  5  I+    0:00.01 - /usr/local/libexec/cabal/shellcheck -

Diff Detail

Repository
rP FreeBSD ports repository
Lint
No Lint Coverage
Unit
No Test Coverage
Build Status
Buildable 38708
Build 35597: arc lint + arc unit