vn_open_vnode(): handle error when fp == NULL
ClosedPublic
Actions

Authored by kib on Apr 19 2021, 10:32 AM.

Details

Reviewers: None
Commits: rG54f98c4dbf9b: vn_open_vnode(): handle error when fp == NULL

Summary

If VOP_ADD_WRITECOUNT() or adv locking failed, so VOP_CLOSE() needs to be called, we cannot use fp fo_close() when there is no fp. This occurs when e.g. kernel code directly calls vn_open() instead of the open(2) syscall.

In this case, VOP_CLOSE() can be called directly, after possible lock upgrade.

Reported by: nvass@gmx.com
PR: 255119

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

kib requested review of this revision.Apr 19 2021, 10:32 AM

kib created this revision.

This fixes the issue for me. I have started a full test on mercat1.

emaste added a subscriber: emaste.Apr 20 2021, 2:59 PM

In D29830#669416, @pho wrote:

This fixes the issue for me. I have started a full test on mercat1.

I completed a full stress2 test without seeing any issues.

This revision was not accepted when it landed; it landed in state Needs Review.Apr 21 2021, 3:08 PM

Closed by commit rG54f98c4dbf9b: vn_open_vnode(): handle error when fp == NULL (authored by kib). · Explain Why

This revision was automatically updated to reflect the committed changes.

kib added a commit: rG54f98c4dbf9b: vn_open_vnode(): handle error when fp == NULL.

Revision Contents
Changeset List

Path

Size

sys/

kern/

vfs_vnops.c

32 lines

Diff 87871

View Options

vn_open_vnode(): handle error when fp == NULLClosedPublicActions