Page MenuHomeFreeBSD

Fix path returned by FreeBSD Ports Search
ClosedPublic

Authored by se on Apr 19 2021, 10:05 AM.

Details

Summary

The path returned by ports.cgi for e.g. inclusion in the URLs in the FreeBSD Ports Search results pages has not been updated to point to the GIT repository instead of SVNWEB.

The same URL change is required in man.cgi.

I do not know how cgi-style.pl is used on the web-site, but it also has a reference to svnweb.freebsd.org (and thus SVN) that should be changed to point at the Git repository.

Test Plan

Apply diff, search for a port, e.g.:

https://www.freebsd.org/cgi/ports.cgi?query=yaze-ag&stype=name

Click on the "Description" link - the pkg-descr file should be displayed.

Diff Detail

Repository
R9 FreeBSD doc repository
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

se requested review of this revision.Apr 19 2021, 10:05 AM
se created this revision.

Bug tracked in https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=255215 - close when the review is accepted and committed ...

The suggested path did not lead to the same representation of the file as was provided by the svnweb link.

The patch has been updated to return the "plain" file.

se edited the summary of this revision. (Show Details)

Add 2 more files in the cgi sub-directory that have references to svnweb.freebsd.org and thus may link to out-dated or non-existent files.

I just wanted to say thanks for doing this as I hit the ports.cgi problem last night and was confused. Thanks!

Update to fix all paths in this file: Category, package name, Description, Changes

This patch has been tested on a replica of the FreeBSD web-site.

The previously uploaded diff contained only the changes to ports.cgi, not man.cgi and cgi-style.pl.

This upload brings the changes to the latter two files back.

The changes to all 3 files have been tested on the web-server replica.

Add a fix to the URL of "Also listed in" entries.

Tested on the web-server replica.

This revision is now accepted and ready to land.Apr 29 2021, 3:43 PM