Page MenuHomeFreeBSD

pf: Refactor state killing
ClosedPublic

Authored by kp on Apr 16 2021, 5:52 PM.

Details

Summary

Extract the state killing code from pfioctl() and rephrase the filtering
conditions for readability.

No functional change intended.

MFC after: 1 week
Sponsored by: Rubicon Communications, LLC ("Netgate")

Diff Detail

Repository
rG FreeBSD src repository
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

kp requested review of this revision.Apr 16 2021, 5:52 PM
eri requested changes to this revision.Apr 16 2021, 7:29 PM
eri added a subscriber: eri.
eri added inline comments.
sys/netpfil/pf/pf_ioctl.c
2552

You should invert the check here to !=

This revision now requires changes to proceed.Apr 16 2021, 7:29 PM
This revision was not accepted when it landed; it landed in state Needs Review.Apr 20 2021, 11:23 AM
Closed by commit rG586aab9e0aa6: pf: Refactor state killing (authored by kp). · Explain Why
This revision was automatically updated to reflect the committed changes.