Details

Reviewers

dbaio
garga

Commits

R11:983b00be9494: sysutils/procenv: Update to 0.55

Summary

sysutils/procenv: Update to 0.55

- Take MAINTAINER'ship
- reorder Makefile (portclippy)
- deleted patches:
files/patch-configure.ac
files/patch-src_platform_freebsd_platform-freebsd.h
because changes were included upstream

ChangeLog: https://github.com/jamesodhunt/procenv/blob/0.55/NEWS

Reviewed by:	daniel.engberg.lists@pyret.net
Approved by:	dbaio, garga (mentors)
Differential Revision:	https://reviews.freebsd.org/D29689

Test Plan

poudriere testport logs:

114amd64 11.4-RELEASE-p8 amd64
114i386 11.4-RELEASE-p8 i386
122amd64 12.2-RELEASE-p4 amd64
122i386 12.2-RELEASE-p4 i386
140amd64 14.0-CURRENT amd64
140i386 14.0-CURRENT i386

Diff Detail

Repository

R11 FreeBSD ports repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

eduardo created this revision.Apr 10 2021, 3:13 AM

Herald added a subscriber: mat. · View Herald TranscriptApr 10 2021, 3:13 AM

eduardo requested review of this revision.Apr 10 2021, 3:13 AM

eduardo edited the summary of this revision. (Show Details)Apr 10 2021, 3:16 AM

Minor style suggestions

sysutils/procenv/Makefile
4	Minor style fix PORTVERSION --> DISTVERSION See "Table 5.2. Package Naming Examples" in Porters Handbook
25	Use USES= localbase instead?

use DISTVERSION instead of PORTVERSION
use USES=localbase instead of CFLAGS and LDFLAGS

I've adjusted the commit message to include Daniel's review.

This revision is now accepted and ready to land.Apr 10 2021, 1:01 PM

Wait a moment @eduardo

This revision now requires changes to proceed.Apr 10 2021, 1:04 PM

Could you add PATCH_DEBUG=yes on your poudriere make.conf and exec a new build?
I'm receiving patch issues when trying to build it.

Update diff to reflect 2 files deleted from files patches dir because they were included upstream.

Sent refreshed diff with "git diff -U999999 > /tmp/D29689.diff"

Herald added a subscriber: jonathan. · View Herald TranscriptApr 12 2021, 7:57 AM

I've refreshed 'poudriere testport' logs

sysutils/procenv/Makefile

It works very well thanks and there is no need to use LDFLAGS either:

(...)
checking for library containing sysinfo... -lsysinfo
(...)
Check unit test framework   :

    Libraries:

    libapparmor                 : no
    libselinux                  : no
    libcap                      : no
    libnuma                     : no
    libpthread                  : yes
    libkvm                      : yes
    > libsysinfo / sysinfo        : yes <

25–26

fix build with devel/libsysinfo dependecy:
https://github.com/jamesodhunt/procenv/issues/19

eduardo edited the summary of this revision. (Show Details)Apr 12 2021, 8:18 AM

eduardo edited the summary of this revision. (Show Details)

mat added inline comments.Apr 12 2021, 1:41 PM