Page MenuHomeFreeBSD

sysutils/procenv: update to 0.55
ClosedPublic

Authored by eduardo on Apr 10 2021, 3:13 AM.

Details

Summary
sysutils/procenv: Update to 0.55

- Take MAINTAINER'ship
- reorder Makefile (portclippy)
- deleted patches:
files/patch-configure.ac
files/patch-src_platform_freebsd_platform-freebsd.h
because changes were included upstream

ChangeLog: https://github.com/jamesodhunt/procenv/blob/0.55/NEWS

Reviewed by:	daniel.engberg.lists@pyret.net
Approved by:	dbaio, garga (mentors)
Differential Revision:	https://reviews.freebsd.org/D29689
Test Plan

Diff Detail

Repository
R11 FreeBSD ports repository
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

Minor style suggestions

sysutils/procenv/Makefile
4

Minor style fix

PORTVERSION --> DISTVERSION
See "Table 5.2. Package Naming Examples" in Porters Handbook

24

Use USES= localbase instead?

  • use DISTVERSION instead of PORTVERSION
  • use USES=localbase instead of CFLAGS and LDFLAGS
dbaio edited the summary of this revision. (Show Details)

I've adjusted the commit message to include Daniel's review.

This revision is now accepted and ready to land.Apr 10 2021, 1:01 PM
dbaio requested changes to this revision.Apr 10 2021, 1:04 PM

Wait a moment @eduardo

This revision now requires changes to proceed.Apr 10 2021, 1:04 PM

Could you add PATCH_DEBUG=yes on your poudriere make.conf and exec a new build?
I'm receiving patch issues when trying to build it.

eduardo marked 2 inline comments as done.

Update diff to reflect 2 files deleted from files patches dir because they were included upstream.

Sent refreshed diff with "git diff -U999999 > /tmp/D29689.diff"

I've refreshed 'poudriere testport' logs

sysutils/procenv/Makefile
24

It works very well thanks and there is no need to use LDFLAGS either:

(...)
checking for library containing sysinfo... -lsysinfo
(...)
Check unit test framework   :

    Libraries:

    libapparmor                 : no
    libselinux                  : no
    libcap                      : no
    libnuma                     : no
    libpthread                  : yes
    libkvm                      : yes
    > libsysinfo / sysinfo        : yes <
24–25

fix build with devel/libsysinfo dependecy:
https://github.com/jamesodhunt/procenv/issues/19

eduardo edited the summary of this revision. (Show Details)
sysutils/procenv/Makefile
18

This is badly orderered, needs some vertical whitespace before USES.

add vertical whitespace before USES

sysutils/procenv/Makefile
13

You can remove this, it's already on LIB_DEPENDS.

eduardo marked an inline comment as done.

remove ${LOCALBASE}/include/sys/sysinfo.h:devel/libsysinfo from BUILD_DEPENDS

This revision is now accepted and ready to land.Apr 21 2021, 2:16 PM
This revision was automatically updated to reflect the committed changes.
eduardo marked an inline comment as done.