Page MenuHomeFreeBSD

x11/libxkbcommon: update to 1.2.1
AbandonedPublic

Authored by jbeich on Apr 9 2021, 3:08 AM.

Details

Reviewers
manu
Group Reviewers
x11
Summary

Proposed commit message:

x11/libxkbcommon: update to 1.2.1

- Add USE_LDCONFIG per portlint [1]
- Add EVDEV option for `xkbcli interactive-evdev` [1]
- Add WAYLAND option for `xkbcli interactive-wayland`
- Simplify OSVERSION check to avoid bsd.port.pre.mk (and bsd.port.options.mk)

Changes:	https://github.com/xkbcommon/libxkbcommon/compare/xkbcommon-1.1.0...xkbcommon-1.2.1
Reported by:	portscout
PR:		254583 [1]
Submitted by:	Evgeniy Khramtsov <2khramtsov@gmail.com> [1]
Approved by:	<someone here>
xDifferential Revision:	<this review>

Should I replace Submitted by (FreeBSD style) with Co-authored-by (Linux style) in order to let GitHub better track attribution?

If desired I can split into multiple commits but then Phabricator would get in the way by requiring to create separate differentials. Better move x11 reviews to GitHub or Gitea (e.g., codeberg) but not GitLab (UI is too slow).

Test Plan

Builds OK:

  • 11.4 amd64
  • 11.4 i386
  • 12.2 aarch64
  • 12.2 amd64
  • 12.2 i386
  • 13.0 amd64
  • 13.0 i386
  • 14.0 aarch64
  • 14.0 amd64
  • 14.0 armv6
  • 14.0 armv7
  • 14.0 i386
  • gcc10 (mimic powerpc64)
  • gcc11
  • inversed options (EVDEV=off WAYLAND=off X11=off)

Runtime OK:

  • poudriere log on 11.4 contains -Ddefault-rules=xorg
  • sway + gtk3 (firefox, emacs) + mpv via dogfooding
  • wlvncc with bhyve
  • wlfreerdp with Windows 10
  • xkbcli interactive-evdev on hkbd(4) (aka sysutils/iichid on FreeBSD < 13) with us layout
  • xkbcli interactive-wayland on sway with us(dvp) layout
  • xkbcli interactive-x11 on xwayland-devel with us(dvp) layout

Diff Detail

Repository
rP FreeBSD ports repository
Lint
Lint Skipped
Unit
Unit Tests Skipped

Event Timeline

jbeich requested review of this revision.Apr 9 2021, 3:08 AM
  • Re-upload with full context via git format-patch -1 -U9999

LGTM
For Submitted-by you can git commit --author=...

This revision is now accepted and ready to land.Apr 9 2021, 8:00 AM

Landed as series of commits. Phabricator doesn't track Git-based ports/ repo yet.

For Submitted-by you can git commit --author=...

Not all changes can be split into logical units authored by a single person. In this case splitting was possible. Can I expect the same from x11 team? ;)

Landed as series of commits. Phabricator doesn't track Git-based ports/ repo yet.

For Submitted-by you can git commit --author=...

Not all changes can be split into logical units authored by a single person. In this case splitting was possible. Can I expect the same from x11 team? ;)

What do you mean ?