Move explanations of commit keywords to the separate line.
AbandonedPublic
Actions

Authored by arrowd on Apr 8 2021, 11:08 AM.

Details

Reviewers

imp
emaste

Group Reviewers

Contributor Reviews (src)

Summary

This removes the need to delete the explanation string when you actually want to fill one of these fields.

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 38402
Build 35291: arc lint + arc unit

Event Timeline

arrowd requested review of this revision.Apr 8 2021, 11:08 AM

arrowd created this revision.

Harbormaster completed remote builds in B38402: Diff 87015.Apr 8 2021, 11:08 AM

lwhsu added a reviewer: emaste.Apr 8 2021, 11:24 AM

We went the other way already via D27664 because the commit message is quite long with the file list included. I don't object to undoing this but we should discuss on the list (along with the commit mail format questions etc.)

I like your variant more.

For some reason, I swapped the diff of your revision in my head -_\

Ok, so to get this in we need a discussion on the ML? Which one would you suggest?

For some reason, I swapped the diff of your revision in my head

Ah, yes so there are three possibilities:

What's in the tree now, Tag: <Description>
Pre D27664 which included block with all of the Tag:s followed by a block of Tag: <Description>
This review, Tag: and <Description> interspersed

I would suggest freebsd-git and/or freebsd-hackers for the discussions.

arrowd abandoned this revision.Apr 19 2021, 2:46 PM

Revision Contents
Changeset List

Path

Size

tools/

git/

hooks/

prepare-commit-msg

42 lines

Diff 87015

View Options

tools/tools/git/hooks/prepare-commit-msg

Move explanations of commit keywords to the separate line.AbandonedPublicActions