Page MenuHomeFreeBSD

Fix downloading of packages hosted on gitlab

Authored by mfechner on Apr 7 2021, 3:05 PM.
Referenced Files
Unknown Object (File)
Mon, Jun 17, 3:11 AM
Unknown Object (File)
Sat, Jun 15, 12:41 AM
Unknown Object (File)
Tue, Jun 11, 1:34 PM
Unknown Object (File)
Mon, Jun 10, 4:22 PM
Unknown Object (File)
Sun, Jun 9, 5:29 AM
Unknown Object (File)
Sat, May 25, 10:42 AM
Unknown Object (File)
Tue, May 21, 4:47 AM
Unknown Object (File)
May 17 2024, 9:22 AM


Group Reviewers

Gitlab changed the address beginning of April you can download packages

The new extracted archive will have a different folder name.
Before it was:
now it is:

So all ports using gitlab must regen their distinfo.

This diff also includes an upgrade of gitlab-ce to version 13.10.2, maybe you want only to look to the changes in Mk/

Test Plan

Diff Detail

rP FreeBSD ports repository
Lint Skipped
Tests Skipped

Event Timeline

Probably the recent PR254866 could be solved by this review.
However, why should we continue to use the GL_COMMIT instead of adding the tag?
Example: adding "GL_TAG = v1.4.2" -> ${GL_SITE}/${GL_ACCOUNT}/${GL_PROJECT}/-/archive/${GL_TAG}/${GL_PROJECT}-${GL_TAG}.tar.gz;
of course GL_TAG could be in another review.

mat requested changes to this revision.Apr 8 2021, 10:21 AM

This is probably missing changes in, around line 1709.

Also, with this change, do all the ports using USE_GITLAB still work?

As this changes the hashes, the review should probably include all affected ports.

This revision now requires changes to proceed.Apr 8 2021, 10:21 AM

Thanks @mat for the tip, I updated and now it works.

To make it clear, every port that uses currently does not work. They only build, because FreeBSD distcache have the files.

I will later prepare a new diff that updates the distfile for every effected port.

Could you redo the patch without changing anything except the distinfo files, that is, without the gitlab update?

mfechner edited the test plan for this revision. (Show Details)

Updated all dist files and removed gitlab upgrade.

All ports are now building fine, here the last build log of the ports that where failing:

I think I would rather trust you this all works and let you commit it before too many ports get updated and the patch no longer works.
Can you do it in two commit, one for the Mk bits and one for all the rest?

Thanks, I committed it with two commits and they should be both MFHed to 2021Q2.

I cannot close this review, as it was not fully accepted ;)

This revision is now accepted and ready to land.Apr 12 2021, 1:31 PM

Committed to main and 2021Q2.