Update GNUstep ports

[theraven]

Summary

Update the currently-out-of-date GNUstep ports.

Test Plan

Tested on a 10.0amd64 jail with poudriere testport. Needs testing on 9.x - is there a command to test multiple ports at once?

[bapt]

put your list of ports in a file
poudriere bulk -t -f thefile -j thejail

[antoine]

I can do an exp-run too, I don't know if you tested all ports depending on gnustep?

[theraven]

In D2961#57789, @antoine wrote:

I can do an exp-run too, I don't know if you tested all ports depending on gnustep?

I didn't, but since I'm testing on a 32-core machine I can probably do the equivalent overnight and save some project resource.

[theraven]

Updated the diff fixing a couple of issues after trying

1. poudriere bulk -t -j 100amd64-testport -p theraven -f gnustep_ports

Where gnustep_ports contains every port that includes the word gnustep in its Makefile (therefore including anything with USES=gnustep). This now builds correctly. Build log:

https://reviews.freebsd.org/P67

[bapt]

mail/pantomime/Makefile

13 ↗

(On Diff #6607)

This was already an issue before -liconv should be ${ICONV_LIB} so USES=iconv deals by itself with iconv on 10+ when it is in libc

18 ↗

(On Diff #6607)

Should be USES_OPENSSL=yes (does it only work with portversion of libssl?)

x11/terminal.app/Makefile

21 ↗

(On Diff #6607)

Same comment as above concerning -liconv

[theraven]

mail/pantomime/Makefile

13 ↗

(On Diff #6607)

This breaks it. The problem is that a (transitive) build dependency depends on libiconv. This then means that the libiconv header - which does things like #define iconv_open libiconv_open is installed and picked up during compilation. The linker then complains that libiconv_open is not installed.

18 ↗

(On Diff #6607)

It should work with either.

[bapt]

Added @tijl for the iconv part

@tijl: I think we have an issue with USES=iconv here, as ICONV_LIB is not defined on FreeBSD 10.1 beside the fact that libiconv is pulled in as a dependency which prevent here from using ICONV_LIB instead of hardcoded "-liconv"

@theraven: note that -liconv like this will fail on poudriere on FreeBSD 10.2 and "recent" head because iconv.mk will not grab a dependency on libiconv

[tijl]

mail/pantomime/Makefile

13 ↗

(On Diff #6607)

USES=iconv adds -DLIBICONV_PLUG to CPPFLAGS/CFLAGS/CXXFLAGS to omit those defines so check that the port respects these flags. You should be able to replace -liconv with ${ICONV_LIB} then.

[theraven]

mail/pantomime/Makefile

13 ↗

(On Diff #6607)

Ah, that's the issue - OBJCFLAGS most needs to be set too. For this port and Terminal.app, I can do that, though it would be nice to do in a more generic way.

[theraven]

Fix iconv usage by passing CPPFLAGS to make as OBJCFLAGS

[bapt]

mail/pantomime/Makefile

13 ↗

(On Diff #6619)

OBJCFLAGS are already passed to the env via objc.mk

Just OBJCFLAGS+= CPPFLAGS in your port

[theraven]

mail/pantomime/Makefile

13 ↗

(On Diff #6619)

This doesn't appear to work (and neither does OBJCFLAGS += ${CPPFLAGS})

[tijl]

mail/pantomime/Makefile

13 ↗

(On Diff #6619)

Maybe USES=iconv should just add -DLIBICONV_PLUG to OBJCFLAGS too.

[theraven]

Address iconv issues.

USES= iconv now sets the correct flag in OBJCFLAGS
USES= gnustep now propagates OBJCFLAGS into the stupidly named variable that GNUstep Make uses.

[tijl]

Mk/Uses/gnustep.mk

36 ↗

(On Diff #6622)

Maybe move FLAGS to the second case below because there's no ${FLAGS} variable. And move LDFLAGS from below here.

mail/pantomime/Makefile

16 ↗

(On Diff #6622)

s/USES_OPENSSL/USE_OPENSSL/